test : Add E2E test for buildpacks build strategy #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
force-pushed
the
pr/buildpacks-build-it
branch
2 times, most recently
from
fafa459
to
4a12957
Compare
sunix
approved these changes
Jun 4, 2024
manusa
reviewed
Jun 5, 2024
| if (result.getExitCode() != 0) { | ||
| throw new IOException(String.format("Error in listing docker volumes: %s", result.getOutput())); | ||
| } | ||
| return Arrays.asList(result.getOutput().replace("\r", "").split("\n")); |
There was a problem hiding this comment.
Could we use a common regex for all systems \r?\n
manusa
reviewed
Jun 5, 2024
Comment on lines
+43
to
+60
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.6.1</version> | ||
| <configuration> | ||
| <source>1.8</source> | ||
| <target>1.8</target> | ||
| </configuration> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.codehaus.mojo</groupId> | ||
| <artifactId>exec-maven-plugin</artifactId> | ||
| <version>1.5.0</version> | ||
| <configuration> | ||
| <mainClass>org.eclipse.jkube.sample.helloworld.App</mainClass> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
We'll need to look into this when we refactor to avoid having parents.
Maybe just create a bom project that can be used as a dependency.
manusa
requested changes
Jun 5, 2024
+ Added a test BuildPacksBuildStrategyK8sITCase that would be activated in others profile + Add a minimal test project in `projects-to-be-tested/maven/buildpacks/simple` directory for abovementioned integration test Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/buildpacks-build-it
branch
from
4a12957
to
48adb5e
Compare
manusa
approved these changes
Jun 5, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to eclipse-jkube/jkube#3097
others profile
projects-to-be-tested/maven/buildpacks/simpledirectory forabovementioned integration test
Signed-off-by: Rohan Kumar [email protected]