ci : Install virtiofsd only when runner os is Ubuntu 24.04 #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
force-pushed
the
pr/ci-crc-okd-install-virtiofsd-conditionally
branch
3 times, most recently
from
2333ed0
to
1efdbc9
Compare
rohanKanojia
force-pushed
the
pr/ci-crc-okd-install-virtiofsd-conditionally
branch
from
1efdbc9
to
988b845
Compare
Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/ci-crc-okd-install-virtiofsd-conditionally
branch
from
988b845
to
269fa48
Compare
manusa
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitHub is rolling out Ubuntu 24.04 on it's runners, sometimes runner os is selected as 22.04 (where
virtiofsdpackage required by CRC is already installed), sometimes it's 24.04 (wherevirtiofsdpackage is not installed)Add a conditional
ifstatement to install it only in case of 24.04