Issue #3613: Fix/unnecessary semicolon #3640
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ube#3613) Signed-off-by: curiousbud [email protected] Helped-by: curiousbud [email protected]
curiousbud
requested review from
manusa,
rohanKanojia and
sunix
as code owners
Eclipse JKube CI ReportStarted new GH workflow run for #3640 (2025-01-24T15:43:20Z) ⚙️ JKube E2E Tests (12952599593)
|
CHANGELOG.md
Outdated
| @@ -21,6 +21,7 @@ Usage: | |||
| ./scripts/extract-changelog-for-version.sh 1.3.37 5 | |||
| ``` | |||
| ### 1.19-SNAPSHOT | |||
| * Fix #3613: remove unnecessary semicolon in HealthCheckMode.java | |||
There was a problem hiding this comment.
This is a minor cleanup change, there is no need to add changelog for this change.
There was a problem hiding this comment.
Should I remove it and raise a PR again?...I apologise if it sounds silly but I'm still quite new to open source....
There was a problem hiding this comment.
You can use git commit --amend to change your commit and force push. No need to create a new PR
There was a problem hiding this comment.
I have completed the previous request is it ready for a merge now?
There was a problem hiding this comment.
Hare you pushed your changes to github?
There was a problem hiding this comment.
yes I have, was there any mistake?
There was a problem hiding this comment.
yes I have, was there any mistake?
Yes, I can still see these changes in your PR. I think you're misunderstanding. You need to revert changes done to this file.
There was a problem hiding this comment.
I have made the changes to the PR.
There was a problem hiding this comment.
An unrelated change is still present in the changelog. Could you please revert this too?
curiousbud
force-pushed
the
fix/unnecessary-semicolon
branch
from
07094c7 to
20f35d5
Compare
curiousbud
commented
Jan 24, 2025
|
rohanKanojia
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3613
The class HealthCheckMode presents the issue: Unnecessary semicolon
;.The following line:
jkube/jkube-kit/config/image/src/main/java/org/eclipse/jkube/kit/config/image/build/HealthCheckMode.java
Line 27 in 5da6068:
cmd;has been changed to:
cmdType of change
Checklist