Skip to content

Commit

Permalink
Check if HTTPS tests using system cert pool can be ran on Windows(and…
Browse files Browse the repository at this point in the history
… possibly Mac OS X (#85)

[#83] Check if HTTPS tests using system cert pool can be ran on Windows(and possibly Mac OS X

- test is now skipped, instead of error(at least on Windows 10),
will wait upgrading to newer go versions(1.20.x) to test the new API to add certificates

Signed-off-by: Georgi Boyvalenkov <[email protected]>
  • Loading branch information
gboyvalenkov-bosch authored Feb 27, 2023
1 parent 05d9e57 commit 4b8ee90
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions uploaders/common_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import (
"net/http"
"os"
"reflect"
"runtime"
"testing"
)

Expand Down Expand Up @@ -160,9 +159,6 @@ func isCertAddedToSystemPool(t *testing.T, certFile string) bool {
func setSSLCerts(t *testing.T) {
t.Helper()

if runtime.GOOS != "linux" {
t.Skip("this test only runs on Linux.")
}
sslCertFile = os.Getenv(sslCertFileEnv)
err := os.Setenv(sslCertFileEnv, validCert)
if err != nil {
Expand Down

0 comments on commit 4b8ee90

Please sign in to comment.