Remove domain classes #3939
Merged
Remove domain classes #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/request-license-review |
License review requests: After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status. Workflow run (with attached summary files): |
dseurotech
force-pushed
the
refactorings/removeDomainClasses
branch
2 times, most recently
from
0ea8658 to
a83500e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3939 +/- ##
=============================================
- Coverage 20.74% 20.57% -0.17%
- Complexity 6 8 +2
=============================================
Files 1951 1916 -35
Lines 41767 41777 +10
Branches 3956 3970 +14
=============================================
- Hits 8664 8596 -68
- Misses 32700 32776 +76
- Partials 403 405 +2
|
dseurotech
force-pushed
the
refactorings/removeDomainClasses
branch
13 times, most recently
from
7332bd6 to
2b0c919
Compare
dseurotech
force-pushed
the
refactorings/removeDomainClasses
branch
3 times, most recently
from
03574b9 to
a1663f0
Compare
…e dependencies in the future Signed-off-by: dseurotech <[email protected]>
…y methods Signed-off-by: dseurotech <[email protected]>
… wiring to the ones in the database Signed-off-by: dseurotech <[email protected]>
… included in the equality comparison, as it has no effect at all (and could be removed completely as a property) Signed-off-by: dseurotech <[email protected]>
… and present in the DB Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
dseurotech
force-pushed
the
refactorings/removeDomainClasses
branch
from
a1663f0 to
e2e1439
Compare
Coduz
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the PR
This PR replaces cumbersome Domain classes with String constants and moves the declaration of expected Domains to a more flexible DI mechanism.
Related Issue
This PR fixes/closes 3938
Description of the solution adopted
This PR replaces Domain classes with String constants in a Domains utility class in kapua-commons (just to find all instances), and moves the declaration of desired Domains to Guice's Wiring.
Also, a DB populator pattern is introduced - used to programmatically initialise all necessary data once the db tables have been initialized. The first instance of such populators is a class which compares Domains declared in wiring to the ones present in the database, creating the missing one and logging discrepancies.
Any side note on the changes made
Potentially breaking:
org.eclipse.kapua.service.authorization.permission.PermissionFactory#newPermission (all overloads) now take a simple String as first parameter, instead of a Domain.