Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deviceManagementConfiguration): fixed serialization of DeviceConfiguration of Password properties #3965

Merged

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Feb 11, 2024

This PR fixes the handling of the Password (and KuraPassword) properties of the DeviceConfiguration

Related Issue
This is an issue introduced #3837

Description of the solution adopted
Added missing handling of KuraPassword attributes.
Added handling of encrypted attribute for Password/KuraPassword properties

Screenshots
None

Any side note on the changes made
None

…iguration of Password properties

Signed-off-by: Alberto Codutti <[email protected]>
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Feb 11, 2024
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (6b580c5) 21.18% compared to head (f9d3e1d) 21.19%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3965   +/-   ##
==========================================
  Coverage      21.18%   21.19%           
  Complexity        10       10           
==========================================
  Files           1938     1939    +1     
  Lines          41181    41197   +16     
  Branches        3780     3781    +1     
==========================================
+ Hits            8724     8731    +7     
- Misses         32051    32061   +10     
+ Partials         406      405    -1     
Files Coverage Δ
...figuration/xml/KuraXmlConfigPropertiesAdapter.java 77.77% <100.00%> (ø)
...onfiguration/metatype/PasswordPropertyAdapter.java 23.07% <0.00%> (-1.93%) ⬇️
...xml/adapters/ClassBasedXmlPropertyAdapterBase.java 69.56% <66.66%> (+2.89%) ⬆️
...configuration/xml/KuraPasswordPropertyAdapter.java 23.07% <23.07%> (ø)

... and 1 file with indirect coverage changes

@Coduz Coduz merged commit 1cf3fad into eclipse-kapua:develop Feb 11, 2024
33 checks passed
@Coduz Coduz deleted the fix-deviceManagementConfigurationPassword branch February 11, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant