Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:fix: Fix service client ack mode #4008

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

riccardomodanese
Copy link
Contributor

Brief description of the PR.
Changed the session acknowledge from CLIENT_ACKNOWLEDGE to AUTO since the client doesn't ACK any message.
This is causing messages accumulation on service broker side and lead to a crash

Related Issue
none

Description of the solution adopted
See the brief descrition

Screenshots
none

Any side note on the changes made
none

@riccardomodanese riccardomodanese added the Bug This is a bug or an unexpected behaviour. Fix it! label Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 16.87%. Comparing base (3025da1) to head (52d50b0).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4008      +/-   ##
=============================================
- Coverage      21.09%   16.87%   -4.22%     
  Complexity        10       10              
=============================================
  Files           1954     1989      +35     
  Lines          41430    51787   +10357     
  Branches        3801     4420     +619     
=============================================
  Hits            8739     8739              
- Misses         32287    42644   +10357     
  Partials         404      404              
Files Coverage Δ
...lipse/kapua/client/security/amqpclient/Client.java 0.00% <0.00%> (ø)
...a/broker/artemis/plugin/security/ServerPlugin.java 0.00% <0.00%> (ø)
...broker/artemis/plugin/security/SecurityPlugin.java 0.00% <0.00%> (ø)
.../artemis/plugin/security/metric/PublishMetric.java 0.00% <0.00%> (ø)

... and 35 files with indirect coverage changes

@Coduz Coduz merged commit 21d4941 into develop Apr 3, 2024
63 of 65 checks passed
@Coduz Coduz deleted the fix-service_client_ack_mode branch July 11, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants