Relocatable Compilation support for Method Handles in Eclipse OpenJ9 #5897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relo type is needed in Eclipse OpenJ9 to relocate method pointers that are special and known within the VM. Signed-off-by: Irwin D'Souza <[email protected]>
dsouzai
requested review from
0xdaryl,
Leonardo2718,
mstoodle and
vijaysun-omr
as code owners
0xdaryl
reviewed
Apr 7, 2021
| @@ -157,15 +157,17 @@ OMR::ResolvedMethodSymbol::ResolvedMethodSymbol(TR_ResolvedMethod * method, TR:: | |||
| // | |||
| if ((_methodIndex > JITTED_METHOD_INDEX && !_resolvedMethod->isSameMethod(comp->getJittedMethodSymbol()->getResolvedMethod())) | |||
| || comp->isDLT() | |||
| || (comp->getOption(TR_UseSymbolValidationManager) && comp->compileRelocatableCode())) | |||
| || comp->compileRelocatableCode()) | |||
There was a problem hiding this comment.
Please fix copyright header.
There was a problem hiding this comment.
Didn't OMR have at one point a copyright header checker? Do you know why it was removed?
In a relocatable compilation, if the resolved method denotes an interpreted method, ensure that the resolved method symbol also denotes it is interpreted. Signed-off-by: Irwin D'Souza <[email protected]>
|
Copyright updated. |
|
Jenkins build all |
0xdaryl
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes necessary to support the Method Handle feature in Eclipse OpenJ9 (eclipse-openj9/openj9#4850), namely: