-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve arraytranslateEvaluator for Power #7649
Conversation
This commit removes the code generation for checking length == 0 in arraytranslateEvaluator for Power. The helper functions for arraytranslate are responsible for checking the case of length == 0.
The arraytranslate evaluator generates code like this without this change:
This commit removes the The performance degrades with this change when the length is zero, but I assume that does not happen very often. |
Jenkins build plinux,aix |
There is no need for a coordinated merge. eclipse-openj9/openj9#21087 is to be merged first, and this PR to follow. The test failure on plinux is a known problem: Issue #6571:
|
@zl-wang FYI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit removes the code generation for checking length == 0 in arraytranslateEvaluator for Power.
The helper functions for arraytranslate are responsible for checking the case of length == 0.