Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow length 0 in arrayTranslateTRTO for Power #21087

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Feb 10, 2025

This commit changes arrayTranslateTRTO helper function for Power to handle the case of length zero.

This commit changes arrayTranslateTRTO helper function for Power to
handle the case of length zero.
@knn-k
Copy link
Contributor Author

knn-k commented Feb 10, 2025

__arrayTranslateTRTO branches to .L.__alignResidue_TRTO when the length is shorter than 8 or 23 (depending on ALIGNLOOP). This commit adds a check for the case of length zero to .L.__alignResidue_TRTO so that the caller side can stop checking the case before calling the helper function.
All other three arraytranslate helper functions accept zero as the length.

@knn-k
Copy link
Contributor Author

knn-k commented Feb 10, 2025

Jenkins test sanity plinux,aix jdk17 depends eclipse-omr/omr#7649

@knn-k
Copy link
Contributor Author

knn-k commented Feb 10, 2025

Jenkins test sanity.openjdk aix jdk17 depends eclipse-omr/omr#7649

Re-running as the previous job failed due to an infrastructure problem.

[2025-02-10T04:15:22.440Z] XML output with verification to /home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_ppc64_aix_Personal_testList_2/aqa-tests/TKG/output_17391559119732/jdk_security2_1/work
[2025-02-10T04:27:19.884Z] Cannot contact p8-java1-ibm10: java.lang.InterruptedException

@knn-k
Copy link
Contributor Author

knn-k commented Feb 10, 2025

Jenkins test sanity.openjdk aix jdk17 depends eclipse-omr/omr#7649

@knn-k
Copy link
Contributor Author

knn-k commented Feb 11, 2025

sanity.functional contains a test for arraytranslateTRTO in https://github.com/eclipse-openj9/openj9/blob/master/test/functional/JIT_Test/src/jit/test/tr/arrayTranslate/ArrayTranslateTest.java, and the test checks the case of length zero.

There are some failures with javax/crypto on AIX: See #19962

@knn-k knn-k marked this pull request as ready for review February 11, 2025 07:51
@knn-k
Copy link
Contributor Author

knn-k commented Feb 11, 2025

A PR in OMR stops checking the length in the caller side.

@knn-k
Copy link
Contributor Author

knn-k commented Feb 12, 2025

@zl-wang FYI.

@knn-k knn-k requested a review from zl-wang February 14, 2025 02:23
@zl-wang
Copy link
Contributor

zl-wang commented Feb 19, 2025

don't you need to handle zero element in all 4 helpers? i only saw it is handled in one.

@knn-k
Copy link
Contributor Author

knn-k commented Feb 19, 2025

It is safe to pass zero as the length to the other three helper functions.
arrayTranslateTRTO is the only helper that doesn't accept zero length.

Copy link
Contributor

@zl-wang zl-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok then.

@0xdaryl 0xdaryl self-assigned this Feb 21, 2025
@0xdaryl 0xdaryl merged commit 5b2ffe7 into eclipse-openj9:master Feb 21, 2025
7 of 9 checks passed
@knn-k knn-k deleted the pArrayTranslateTRTO branch February 21, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants