Add AOT support for Method Handles

[harryyu1994]

NonSVM implementation summary:

AOT compile run

• our record needs these 4 pieces of information

InlinedSiteIndex
cpIndex
constantPool (not sure why this pointer is needed as we can get constantPool from inlinedSiteIndex)
classChain of j9class of arbitrary object

• introduce TR_ResolvedRelocatableJ9Method::validateArbitraryObjectClassFromConstantPool which will handle adding both SVM and NonSVM validation records
• looking to reuse storeValidationRecordIfNecessary, add new type TR_ValidateArbitraryObjectClass

AOT load run

• TR_RelocationRecordValidateArbitraryObjectClass::applyRelocation() should contain the special logic for the AOT load run validation
  • use InlinedSiteIndex to find J9Method then from J9Method we can find J9ConstantPool
  • J9ConstantPool[cpIndex] gives us the arbitrary object
  • from the arbitrary object we can get J9Class
  • check the J9Class against classChain for the shape check
  • call getClassFromSignature() on classChain head name for the visibility check
• TR_RelocationRecordValidateArbitraryObjectClass will need to be created, could extend from TR_RelocationRecordValidateClass, only applyRelocation() need to be overriden
• initializeCommonAOTRelocationHeader and dumpRelocationHeaderData and TR_RelocationRecord::create all need a new case (TR_ValidateArbitraryObjectClass)
• Issue: AOT Support for Method Handles #4850
• depends on: Add method handle AOT support eclipse-omr/omr#5750

Signed-off-by: Harry Yu [email protected]

[harryyu1994]

For the getClassFromSignature() visibility check part, how does one extract the first class from the classChain? @dsouzai
For this part i think we are trying to get a J9Class pointer using the class name of the patched object (first item in the classChain) and then compare that J9Class pointer to the J9Class of the current patched object.

[harryyu1994]

For the getClassFromSignature() visibility check part, how does one extract the first class from the classChain? @dsouzai
For this part i think we are trying to get a J9Class pointer using the class name of the patched object (first item in the classChain) and then compare that J9Class pointer to the J9Class of the current patched object.

I think I have found it: J9ROMClass *romClass = _fej9->sharedCache()->startingROMClassOfClassChain(classChain);

[harryyu1994]

NonSVM implementation is finished.
I still have a few things to sort out for the SVM implementation. (I want to revisit a few concepts regarding SVM)
Another thing, wondering if you know how we can disable inlining for method handle AOT compile so that this implementation can be tested.

[harryyu1994]

Build MethodHandle JDK

• git clone [email protected]:ibmruntimes/openj9-openjdk-jdk16.git
• bash get_source.sh
• cd openj9
• git remote add babsingh [email protected]:babsingh/openj9.git
• git fetch babsingh
• git checkout ojdk_jsr292_final
• cd ../
• bash ./configure --with-freemarker-jar=/root/freemarker.jar --with-boot-jdk=/root/Harry_MethodHandle/bootjdk15 --enable-openjdk-methodhandles
• make clean
• make images
• more information in Test Results for OpenJ9 JDK15/JDK16 with OpenJDK MethodHandles #11458

Testing

cd openj9/test
git clone https://github.com/AdoptOpenJDK/TKG.git
cd TKG
export TEST_JDK_HOME=<path to JDK directory that you wish to test>
export BUILD_LIST=functional
make compile
make _sanity.regular EXTRA_OPTIONS="-Xshare:off"