[0.31 release] Correctly throw UOE from setSecurityManager #14453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, warning messages are no longer being printed when the input argument is null. Revising the fix in eclipse-openj9#14329 to correctly throw UnsupportedOperationException (UOE) in case of a null input argument when the security manager is disallowed. When the security manager is not allowed to be set dynamically, return if the input argument is null. UnsupportedOperationException should only be thrown for a non-null input argument. Fixes: eclipse-openj9#14445 Signed-off-by: Babneet Singh <[email protected]>
pshipton
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, warning messages are no longer being printed when the input
argument is null. Revising the fix in #14329 to correctly throw
UnsupportedOperationException (UOE) in case of a null input argument when the
security manager is disallowed.
When the security manager is not allowed to be set dynamically, return if the
input argument is null. UnsupportedOperationException should only be thrown for
a non-null input argument.
Fixes: #14445
Related: #14447
Signed-off-by: Babneet Singh [email protected]