Error if invokeinterface receiver is reference array

[theresa-m]

Throw an error during bytecode verification if the receiver of invokeinterface is a reference array.
Fix: #19756

[tajila]

Did you run verification tests with this change?

[ChengJin01]

I would suggest to leave these comments out there to avoid any confusion/misconception in the future given it's clearer for developers to understand how to use these constants with the comments put aside.

[theresa-m]

Okay. I was thinking it would be good to have one set of comments, but I don't think there's a risk of this code changing significantly :) I'll add them back.

[ChengJin01]

Did you run verification tests with this change?

@theresa-m, you will need to run internal & open builds to ensure there is no issue introduced with your changes. In addition, please share with us the output of OpenJ9 with the updated fix as compared to RI.

[theresa-m]

The output of OpenJ9 for the test provided in the issue is:

Error: Unable to initialize main class TestInterface
Caused by: java.lang.VerifyError: JVMVRFY021 thrown object not throwable; class=TestInterface, method=method1()V, pc=7
Exception Details:
  Location:
    TestInterface.method1()V @7: JBinvokeinterface
  Reason:
    Type '[LTestInterface$A;' (current frame, stack[0]) is not assignable to 'java/lang/Object'
  Current Frame:
    bci: @7
    flags: { }
    locals: { '[LTestInterface$A;' }
    stack: { '[LTestInterface$A;' }

[ChengJin01]

I will approve the PR once it passes all related internal & open test cases.

[theresa-m]

I updated this change after further testing to make sure the type is not BCV_BASE_TYPE_NULL since BCV_BASE_TYPE_NULL has non-zero arity bits.

[ChengJin01]

I updated this change after further testing to make sure the type is not BCV_BASE_TYPE_NULL since BCV_BASE_TYPE_NULL has non-zero arity bits.

That's correct as a NULL value belongs to reference as per the VM Spec.

[ChengJin01]

LGTM.

[tajila]

jenkins test sanity alinux64 jdk8,jdk21

[tajila]

@theresa-m Please make a 0.47 PR as well

[theresa-m]

#19931 is for 0.47