Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification check for invokeinterface receiver #19938

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

theresa-m
Copy link
Contributor

@theresa-m theresa-m commented Jul 30, 2024

Rework fix for #19756 to address invokeinterface array receiver type and internal test suites.

0.47: #19946

@theresa-m theresa-m force-pushed the invokeinterfacearray branch 3 times, most recently from b3ca5e3 to 3c94a47 Compare July 30, 2024 19:09
@theresa-m
Copy link
Contributor Author

fyi @ChengJin01 after this change the output from TestInterface in #19756 is:

Error: Unable to initialize main class TestInterface
Caused by: java.lang.VerifyError: JVMVRFY021 thrown object not throwable; class=TestInterface, method=method1()V, pc=7
Exception Details:
  Location:
    TestInterface.method1()V @7: JBinvokeinterface
  Reason:
    Type '[LTestInterface$A;' (current frame, stack[0]) is not assignable to 'TestInterface$I'
  Current Frame:
    bci: @7
    flags: { }
    locals: { '[LTestInterface$A;' }
    stack: { '[LTestInterface$A;' }

@ChengJin01
Copy link

ChengJin01 commented Jul 31, 2024

@theresa-m. The output is the expected result that matches the RI's behavior. Please double-check all related test suites (internal & open) to ensure no other issue is introduced with the updated code.

@theresa-m theresa-m changed the title Allow array types for Serializeable and Cloneable Verification check for invokeinterface receiver Jul 31, 2024
@theresa-m theresa-m marked this pull request as ready for review July 31, 2024 18:22
Arrays should be rejected as a receiver for invokeinterface
unless it is being assigned to Serializeable or Cloneable.

Signed-off-by: Theresa Mammarella <[email protected]>
@theresa-m theresa-m force-pushed the invokeinterfacearray branch from 3c94a47 to 9a15c73 Compare August 1, 2024 13:45
Copy link

@ChengJin01 ChengJin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ChengJin01 ChengJin01 requested a review from tajila August 1, 2024 13:48
@tajila
Copy link
Contributor

tajila commented Aug 1, 2024

jenkins test sanity alinux64 jdk17

@tajila tajila merged commit 18c1640 into eclipse-openj9:master Aug 1, 2024
5 checks passed
@theresa-m theresa-m deleted the invokeinterfacearray branch October 11, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants