-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove isPrimitiveValueTypeClass #20398
Remove isPrimitiveValueTypeClass #20398
Conversation
@hzongaro May I ask you to review this change? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a few comments.
9fd2f09
to
7bc96d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes look good. I've noted one typo, but will approve the changes under the assumption that you will correct that.
Also updated code comments where the old primitive value type is referenced Related: eclipse-openj9#18157 Signed-off-by: Annabelle Huo <[email protected]>
7bc96d5
to
ab38690
Compare
Jenkins test sanity.functional,sanity.openjdk xlinux,alinux jdk8,jdk21 |
Jenkins test sanity.functional,extended.functional xlinuxval,alinuxval,zlinuxval,plinuxval jdknext |
Also updated code comments where the old primitive value type is referenced
Related: #18157