WIP: Don't override OpenJ9 SHA with PR ref #7288
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When calling test pipelines, the OpenJ9 SHA should be used rather than the merge ref. Since the merge ref is a moving target, the SHA could change between the compile and the test. We need to ensure we are testing with the same level of OpenJ9 as we compile against. Fixes eclipse-openj9#7287 [skip ci] Signed-off-by: Adam Brousseau <[email protected]>
keithc-ca
reviewed
Sep 30, 2019
| if (params.ghprbPullId && params.ghprbGhRepository == GHPRB_REPO_OPENJ9) { | ||
| SHAS['OPENJ9'] = "origin/pr/${params.ghprbPullId}/merge" | ||
| } | ||
| echo "Passing test OPenJ9 SHA:${SHAS['OPENJ9']}" |
AdamBrousseau
changed the title
|
Needs something more. When doing a depends build from the ext repo, the SHA passed to test is from the HEAD of the target branch rather than the merge commit. Marked as WIP for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be used rather than the merge ref. Since the merge
ref is a moving target, the SHA could change between
the compile and the test. We need to ensure we are
testing with the same level of OpenJ9 as we compile
against.
Fixes #7287
[skip ci]
Signed-off-by: Adam Brousseau [email protected]