Update callbacks signature #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow to access reason code & properties on on_publish
PierreF
force-pushed
the
update-callbacks-signature
branch
from
3bbd0d0
to
faf62e0
Compare
PierreF
added a commit
that referenced
this pull request
Jan 21, 2024
PierreF
added a commit
that referenced
this pull request
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #659, #687, #656, #715
This add versioning to user-callback. I've make choosing the version mandatory because:
Making the chose of the version mandatory cause a breaking change.
This PR didn't yet updated the README nor the examples/. This is something that need to be done in this PR.
This PR is based from #801 because I want
reason_code > 0to be supported to ease migration.