Quick fix to provide an option to update user directive to mandatory singleton true directive(if not present)

[nburnwal09]

This is to provide quick fix:
In case, user has not entered any singleton directive to true, this change will provide an option to update the same to singleton:=true
this will provide the update option only when there is one set of directive. For multiple sets, we already have an option to add 'singleton' directive to true.

for example:
before the fix:

after applying the Update fix:

[eclipse-pde-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.core/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 3a30b41851b24604202f12f96c757971fd2b5648 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Wed, 5 Mar 2025 10:31:04 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
index 495c43634d..0d96f8a730 100644
--- a/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.core; singleton:=true
-Bundle-Version: 3.20.100.qualifier
+Bundle-Version: 3.20.200.qualifier
 Bundle-Activator: org.eclipse.pde.internal.core.PDECore
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

[nburnwal09]

Have one question here:

Have added the if check in UpdateSingletonToSymbolicName.java(the new class) similar to this in AddSingletonToSymbolicName.java file

eclipse.pde/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/correction/AddSingletonToSymbolicName.java

Lines 55 to 58 in f941e23

	if (fisDirective && TargetPlatformHelper.getTargetVersion() >= 3.1)
	bundle.setHeader(Constants.BUNDLE_MANIFESTVERSION, "2"); //$NON-NLS-1$
	else if (!fisDirective && TargetPlatformHelper.getTargetVersion() < 3.1)
	bundle.setHeader(Constants.BUNDLE_MANIFESTVERSION, null);

I guess this is for maintaining the backward compatibility.
Can someone clarify on this?

[github-actions]

Test Results

   279 files   -   6     279 suites   - 6   48m 1s ⏱️ - 3m 11s
 3 608 tests ±  0   3 531 ✅  -   1   76 💤 ± 0  1 ❌ +1 
10 822 runs   - 194  10 619 ✅  - 166  202 💤  - 29  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 19e410c. ± Comparison against base commit f941e23.