Change the classes with shortcut #2413
Draft
+61
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannisCode
force-pushed
the
tab_change
branch
4 times, most recently
from
21d07b3
to
402bd75
Compare
Test Results 1 820 files - 1 1 820 suites - 1 1h 48m 51s ⏱️ - 7m 26s For more details on these failures, see this check. Results for commit bb64c62. ± Comparison against base commit 0a3c1fd. ♻️ This comment has been updated with latest results. |
Wittmaxi
requested changes
Oct 17, 2024
| * | ||
| * @param folder | ||
| * @return if there are any items which are not shown in the folder (tabs in the | ||
| * >> column) |
There was a problem hiding this comment.
the ">> column" is called "the chevron"
There was a problem hiding this comment.
| /** | ||
| * checks if there are any hidden items | ||
| * | ||
| * @param folder |
| * >> column) | ||
| */ | ||
| private boolean areHiddenItems(CTabFolder folder) { | ||
| for (CTabItem i : folder.getItems()) { |
There was a problem hiding this comment.
| /** | ||
| * Sets the current selection to the second-to-last item in the given direction. | ||
| * | ||
| * @param folder |
There was a problem hiding this comment.
describe folder and forward
jannisCode
force-pushed
the
tab_change
branch
9 times, most recently
from
500e322
to
e40fc60
Compare
jannisCode
force-pushed
the
tab_change
branch
from
e40fc60
to
bb64c62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes the PR started by @Wittmaxi , who also did most of the work here: #1874
The objective of @Wittmaxi ´s PR is to be able to expand the functionality of the nextTab shortcut (default crtl + pgdown) so that after reaching the last tab, one more click changes the active tab back to the first one.
What this PR does
When there are too many tabs open, #1874 still went back to the first tab, ignoring the remaining tabs stored in the chevron (the >> container).
With the changes from this PR, when there are stored tabs in the chevron, clicking once more after the last tab has the same functionality as the default eclipse, going into the chevron.
tabaction.mp4