Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DefaultEclipseStoreConfiguration #355

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

Oscar-21
Copy link
Contributor

Add a @ComponentScan annotation so that spring will register LockAspect as a bean. I have tested this along with an alternative approach which would create the bean explicitly using @ConditionalOnMissingBean. But since the LockAspect class does not need configuration this seemed unnecessary.

Add a ComponentScan annotation so that spring will register LockAspect as a bean.
@Oscar-21
Copy link
Contributor Author

See issue: #356

@zdenek-jonas zdenek-jonas requested a review from fh-ms December 31, 2024 09:42
@fh-ms fh-ms linked an issue Dec 31, 2024 that may be closed by this pull request
@fh-ms fh-ms requested a review from zdenek-jonas December 31, 2024 11:21
@zdenek-jonas
Copy link
Contributor

Thank you for contributing.

@zdenek-jonas zdenek-jonas merged commit 1f55888 into eclipse-store:main Jan 2, 2025
4 checks passed
@fh-ms fh-ms added this to the 2.1.1 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LockAspect not registered as a spring bean.
3 participants