8 communication tests #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hasan Eroglu <[email protected]>
Signed-off-by: Hasan Eroglu <[email protected]>
Signed-off-by: Hasan Eroglu <[email protected]>
Signed-off-by: Hasan Eroglu <[email protected]>
Signed-off-by: Hasan Eroglu <[email protected]>
Signed-off-by: Hasan Eroglu <[email protected]>
Signed-off-by: Hasan Eroglu <[email protected]>
Signed-off-by: Hasan Eroglu <[email protected]>
Signed-off-by: Hasan Eroglu <[email protected]>
Signed-off-by: Hasan Eroglu <[email protected]>
README.md
Outdated
|
|
||
| ### Smart Home Mashup | ||
|
|
||
| See the mashup's [readme](./mashups//smart-home/README.md). |
There was a problem hiding this comment.
Is the double forward slash correct?
| @@ -0,0 +1,66 @@ | |||
| "use strict"; | |||
| /******************************************************************************** | |||
| * Copyright (c) 2023 Contributors to the Eclipse Foundation | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2023 Contributors to the Eclipse Foundation | |
| * Copyright (c) 2024 Contributors to the Eclipse Foundation |
Since it is new?
| @@ -0,0 +1,216 @@ | |||
| "use strict"; | |||
| /******************************************************************************** | |||
| * Copyright (c) 2023 Contributors to the Eclipse Foundation | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2023 Contributors to the Eclipse Foundation | |
| * Copyright (c) 2024 Contributors to the Eclipse Foundation |
There are many more...
Signed-off-by: Hasan Eroglu <[email protected]>
Signed-off-by: Hasan Eroglu <[email protected]>
Signed-off-by: Hasan Eroglu <[email protected]>
Signed-off-by: Hasan Eroglu <[email protected]>
egekorkan
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8, Closes #23.
This PR MUST be merged after #38 is merged.
Note: MQTT tests are problematic since the thing in the repository has properties with "readproperty" operations. We need to either change the logic or fix issues node-wot #980 and node-wot #1241.