fix: removed unused entitys

[Bailonis]

Unit Tests and Features were already pre discussed in code review, and are approved !

[SebastianBezold]

Was this added by accident?

[Bailonis]

No, if we do not have that chart, the workflow for the backend builder will not work, because it says this folder does not have a Chart, but i can give it another name and description

[Bailonis]

Resolved

[SebastianBezold]

This is not resolved :) If you're workflow complains about it, it clearly shows, that there is something wrong with your workflow. /charts/charts -> this means you have a Chart called charts. Is it possible, that a path declaration in your workflow is wrong? Keep in mind: Chart releaser is already looking at the /charts directory, so no need to specify /charts in a path for chart-releaser action

[SebastianBezold]

Ok i think I was a bit confused here, Your chart directory structure is a bit off i think.
In my opinion, you have two options to approach your Chart

1. Flat kubernetes manifests for frontend and backend in a single chart

<repo>
└───charts
    └───demand-capacity-management
        └───Chart.yaml
        └───templates
            └─── deployment-frontend.yaml
            └─── deployment-backend.yaml
            └─── service-frontend.yaml
            └─── service-backend.yaml

2. Build subcharts for frontend and backend and use them as dependencies of a product Chart

<repo>
└───charts
    └───demand-capacity-management
        └───Chart.yaml     <-- Does contain dcm-frontend and dcm-backend as dependency
        └───templates
            <empty>
        └───charts
            └─── dcm-frontend
                └─── Chart.yaml
                └───templates
                    └───deployment.yaml
                    ...
            └─── dcm-backend
                └─── Chart.yaml
                └───templates
                    └───deployment.yaml
                    ...

[Bailonis]

Hi @SebastianBezold thanks for the input, I will follow your advice!

[SebastianBezold]

Hi @Bailonis, I added some review comments. Please have a look. Also, as with the other PR, please ask someone from your team for a review on the changes. I cannot tell, if the things you removed should be removed and if the DB scripts are correctly altered

[SebastianBezold]

Hi @Bailonis,

I could merge this PR, but the chart directory structure still seems to be odd.

/charts/charts/ is wrong. It should be /chart/demand-capacity-management should be the goal