-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R25.03] DCM: KIT Maintenance #1140
base: main
Are you sure you want to change the base?
[R25.03] DCM: KIT Maintenance #1140
Conversation
Create PR, as requested by @LukasSchmetz |
[like] Lukas Schmetz reacted to your message:
…________________________________
From: Philipp ***@***.***>
Sent: Tuesday, February 4, 2025 11:45:06 AM
To: eclipse-tractusx/eclipse-tractusx.github.io ***@***.***>
Cc: Lukas Schmetz ***@***.***>; Review requested ***@***.***>
Subject: [EXT] Re: [eclipse-tractusx/eclipse-tractusx.github.io] [R25.03] DCM: KIT Maintenance (PR #1140)
This message is from an EXTERNAL SENDER – be CAUTIOUS, particularly with links and attachments
________________________________
@ClosedSourcerer<https://github.com/ClosedSourcerer> requested your review on: #1140<#1140> [R25.03] DCM: KIT Maintenance.
—
Reply to this email directly, view it on GitHub<#1140 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4U2R3UDPZ45AJNFGIIZDGL2OCR4FAVCNFSM6AAAAABWOLSQNOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGE3TOMJXGEZDEMA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
Henkel AG & Co. KGaA
Sitz: Düsseldorf, Deutschland
Handelsregister: Amtsgericht Düsseldorf, HRB 4724
Vorsitzende des Aufsichtsrats: Dr. Simone Bagel-Trah
Persönlich haftende Gesellschafterin:
Henkel Management AG
Sitz: Düsseldorf; Deutschland
Handelsregister: Amtsgericht Düsseldorf, HRB 58139
Aufsichtsratsvorsitzende: Dr. Simone Bagel-Trah
Vorstand: Carsten Knobel (Vorsitzender), Mark Dorn, Wolfgang König, Sylvie Nicol, Marco Swoboda
|
[like] Lukas Schmetz reacted to your message:
…________________________________
From: Philipp ***@***.***>
Sent: Tuesday, February 4, 2025 12:18:06 PM
To: eclipse-tractusx/eclipse-tractusx.github.io ***@***.***>
Cc: Lukas Schmetz ***@***.***>; Mention ***@***.***>
Subject: [EXT] Re: [eclipse-tractusx/eclipse-tractusx.github.io] [R25.03] DCM: KIT Maintenance (PR #1140)
This message is from an EXTERNAL SENDER – be CAUTIOUS, particularly with links and attachments
________________________________
Create PR, as requested by @LukasSchmetz<https://github.com/LukasSchmetz>
—
Reply to this email directly, view it on GitHub<#1140 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4U2R3U2ITCPFATU632BP4D2OCVX5AVCNFSM6AAAAABWOLSQNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZTG4ZTONRXHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
Henkel AG & Co. KGaA
Sitz: Düsseldorf, Deutschland
Handelsregister: Amtsgericht Düsseldorf, HRB 4724
Vorsitzende des Aufsichtsrats: Dr. Simone Bagel-Trah
Persönlich haftende Gesellschafterin:
Henkel Management AG
Sitz: Düsseldorf; Deutschland
Handelsregister: Amtsgericht Düsseldorf, HRB 58139
Aufsichtsratsvorsitzende: Dr. Simone Bagel-Trah
Vorstand: Carsten Knobel (Vorsitzender), Mark Dorn, Wolfgang König, Sylvie Nicol, Marco Swoboda
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@stephanbcbauer could you please check and approve as our designated committer for this feature (see issue linked above). Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Why did you change & -> and?
Because the usage of et is normally restricted only to company names. |
@ClosedSourcerer please do not involve all the committer group into a review for a specific KIT change. |
Description
General Maintenance of DCM KIT including bug fixes.
Addresse Issues
eclipse-tractusx/sig-release#898
Added
N/A
Changed
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: