Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R25.03] DCM: KIT Maintenance #1140

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ClosedSourcerer
Copy link
Contributor

@ClosedSourcerer ClosedSourcerer commented Feb 4, 2025

Description

General Maintenance of DCM KIT including bug fixes.

Addresse Issues

eclipse-tractusx/sig-release#898

Added

N/A

Changed

  • Replaced the KIT Logo File
  • Minor Wording fix
  • Removed "&"

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ClosedSourcerer
Copy link
Contributor Author

Create PR, as requested by @LukasSchmetz

@LukasSchmetz
Copy link
Contributor

LukasSchmetz commented Feb 4, 2025 via email

@LukasSchmetz
Copy link
Contributor

LukasSchmetz commented Feb 4, 2025 via email

Copy link

@MWADCM MWADCM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed

Copy link
Contributor

@LukasSchmetz LukasSchmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasSchmetz
Copy link
Contributor

@stephanbcbauer could you please check and approve as our designated committer for this feature (see issue linked above). Thanks

Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Why did you change & -> and?

@ClosedSourcerer
Copy link
Contributor Author

LGTM. Why did you change & -> and?

Because the usage of et is normally restricted only to company names.
Hence "Henkel AG & Co. KGaA" is valid, but "Vision & Mission" is not.

https://de.wikipedia.org/wiki/Et-Zeichen#:~:text=Der%20Duden%20beschreibt%20einen%20eingeschr%C3%A4nkten,angewendet.

@ndr-brt
Copy link
Contributor

ndr-brt commented Feb 12, 2025

@ClosedSourcerer please do not involve all the committer group into a review for a specific KIT change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants