Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add link to our issue template and link the committer list #494

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

FaGru3n
Copy link
Contributor

@FaGru3n FaGru3n commented Nov 15, 2023

Description

  • add link to our contributpr issue template
  • add link to our committer list
  • update reference documentation

fixes #492

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.

INFO Vetted license information was found for all content. No further investigation is required.

@FaGru3n FaGru3n marked this pull request as draft November 15, 2023 12:45
@FaGru3n FaGru3n marked this pull request as ready for review November 15, 2023 12:49
@SebastianBezold
Copy link
Contributor

The text itself is fine, but I'm not sure, if this won't "over advertise" the project contributor role a bit.
We already have a huge number of project contributors, and just from my gut feeling, only half of them need the role, because they are managing labels or actively ask for review.
To make it clear, that this role is only needed in the mentioned cases, I would rather move it to an "optional next steps" section. I think otherwise it could be mistaken as a mandatory step and we miss the chance to describe what the role is needed for and what it entitles for.

What do you think @FaGru3n?

@FaGru3n
Copy link
Contributor Author

FaGru3n commented Nov 15, 2023

The text itself is fine, but I'm not sure, if this won't "over advertise" the project contributor role a bit. We already have a huge number of project contributors, and just from my gut feeling, only half of them need the role, because they are managing labels or actively ask for review. To make it clear, that this role is only needed in the mentioned cases, I would rather move it to an "optional next steps" section. I think otherwise it could be mistaken as a mandatory step and we miss the chance to describe what the role is needed for and what it entitles for.

What do you think @FaGru3n?

good point same "gut feeling" on myside... also while writing it, it was a bit strange to take this as a starting point in a foss community.

will modify it, with explaination how the contributor role is for... such if you want to add this and this you need to become a contributor in our project.

I guess for the many access permissions in former working models all new shifting people think they need a request for access.

@FaGru3n
Copy link
Contributor Author

FaGru3n commented Nov 29, 2023

add chore: add contributor section

@FaGru3n FaGru3n merged commit 6a7c5d9 into main Dec 1, 2023
2 checks passed
@FaGru3n FaGru3n deleted the chore/add-issue-tempalte-to-get-started branch December 1, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more information whom to contact to be a contributor on our web-page
2 participants