-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial release for modular production kit #495
feat: initial release for modular production kit #495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot say much about the content, but maybe some general questions:
- Is it possible to get SVG versions of the images provided? This would ensure, that we can maintain the images.
- Where does the
modular-production-onboarding.pdf
come from? Is there an editable "raw" form of it. This is also related to maintainability of the contents - Is it commonly agreed in KITs, that directory names contain spaces? I see that quite often, but find it uncomfortable, especially when it comes to linking. If the directory structure is present in URLs and links, the spaces always have to be URL encoded to %20 and so on.
All in all the PR looks good to me, but the image and PDF topic should be address somehow (maybe afterwards). The spaces in directories topic is just food for thought 😁
|
PNG files have been replaced with SVG files |
Ok cool thank you. Looks good from my side. I'll add @danielmiehle and @maximilianong to the reviewers section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@maximilianong we should update the how to create a KIT page concerning the directory names and spaces. |
Description
This Pull Request introduces the first version of the Modular Production Kit in the Resiliency Domain in anticipation of the 23.12 release. It includes the Changelog, Adoption and Software Development View as wells as a white paper.
The content of the pull request is created by the Modular Production Team @wehrstedt-jan
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
@maximilianong @danielmiehle @SebastianBezold