Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(draft): new version of TRG 4.02 - Base Images #594

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

carslen
Copy link
Contributor

@carslen carslen commented Jan 15, 2024

related to eclipse-tractusx/sig-infra#375

Introduce recommendation to use minor image tags instead of patch version tags for base images to improve security and compliance handling in our own workflows.

Let the base image maintainers fix their vulnerabilities instead of trying to fix it using bumping patch version image tags in DOCKERFILE.

related to eclipse-tractusx/sig-infra/issues#375

Introduce recommendation to use minor image tags instead of patch version tags for base images to improve security and compliance handling in our own workflows.

Let the base image maintainers fix their vulnerabilities instead of trying to fix it using bumping patch version image tags in `DOCKERFILE`.
Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small changes, i guess

@carslen carslen requested a review from FaGru3n January 17, 2024 13:35
FaGru3n
FaGru3n previously approved these changes Jan 17, 2024
Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM small suggestion

Copy link
Contributor

@SebastianBezold SebastianBezold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the caps vs lowercase Dockerfile

@carslen carslen dismissed stale reviews from SebastianBezold and FaGru3n via 0ee8d43 January 18, 2024 08:54
FaGru3n
FaGru3n previously approved these changes Jan 18, 2024
Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carslen carslen dismissed stale reviews from FaGru3n and SebastianBezold via f62591e January 18, 2024 09:39
Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carslen carslen merged commit 8d11688 into main Jan 18, 2024
3 checks passed
@carslen carslen deleted the docs/TRG-4.02---add-base-image-tags-to-use branch January 18, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants