-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(kit): updated ecopasskit software development view, added new diagrams and adjusted content to reference implementation #631
Conversation
60cded2
to
3626d44
Compare
I am the author of all the images, even if it says that is 47k code changes, no IP check is necessary since I was the one that created them. (They are in svg, because of this it counts as lines of code) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor typos and grammar issues found, apart from that no complaints!
docs-kits/kits/Eco_Pass_KIT/resources/development-view/ecoPassSearchSequence.svg
Outdated
Show resolved
Hide resolved
Linting problems are not from EcoPass KIT |
@matbmoser please resolve the conflict we need to merge it today for the release. |
@maximilianong done! |
Why do we create this PR:
There is the requirement to update the Eco Pass KIT development view
What do we what to do in this PR
We want to update the development view, and add the necessary diagrams, content and descriptions to match the reference implementation of the Digital Product Pass.
What has changed?
Added
Updated
Issues Fixed
Content Review PRs:
Related PRs:
This is the second PR from the EcoPass KIT v2.0.0 Update
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: