Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(kit): updated ecopasskit software development view, added new diagrams and adjusted content to reference implementation #631

Merged
merged 12 commits into from
Mar 6, 2024

Conversation

matbmoser
Copy link
Contributor

@matbmoser matbmoser commented Jan 23, 2024

Why do we create this PR:

There is the requirement to update the Eco Pass KIT development view

What do we what to do in this PR

We want to update the development view, and add the necessary diagrams, content and descriptions to match the reference implementation of the Digital Product Pass.

What has changed?

Added

  • Added new sequence diagrams in software architecture
  • Added detailed data retrieval flow

Updated

  • Updated Software Architecture guide with descriptive documentation

Issues Fixed

  • Corrected links paths to absolute path

Content Review PRs:

Related PRs:

This is the second PR from the EcoPass KIT v2.0.0 Update

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@matbmoser matbmoser added documentation Improvements or additions to documentation website labels Jan 23, 2024
@matbmoser matbmoser self-assigned this Jan 23, 2024
@matbmoser matbmoser requested a review from saudkhan116 January 23, 2024 17:05
@matbmoser
Copy link
Contributor Author

I am the author of all the images, even if it says that is 47k code changes, no IP check is necessary since I was the one that created them. (They are in svg, because of this it counts as lines of code)

Copy link
Contributor

@maxim-bo maxim-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor typos and grammar issues found, apart from that no complaints!

@matbmoser
Copy link
Contributor Author

Linting problems are not from EcoPass KIT

@danielmiehle danielmiehle self-requested a review March 6, 2024 07:36
danielmiehle
danielmiehle previously approved these changes Mar 6, 2024
@maximilianong
Copy link
Contributor

@matbmoser please resolve the conflict we need to merge it today for the release.

@matbmoser
Copy link
Contributor Author

@maximilianong done!

@maximilianong maximilianong merged commit 7af9eb3 into main Mar 6, 2024
4 of 5 checks passed
@maximilianong maximilianong deleted the docs/ecopass-v2-software branch March 6, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation website
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants