Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: publish Dependabot TRG #659

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Conversation

tomaszbarwicki
Copy link
Contributor

PR to publish Dependabot Tractus-X Release Guideline (TRG-2.06):

image image

@RoKrish14
Copy link
Contributor

There is an open PR #60 related to dependabot.yml. The PR also addresses necessary description in the security_tooling.md file.
@tomaszbarwicki Please feel free to drop a review.

@FaGru3n
Copy link
Contributor

FaGru3n commented Feb 13, 2024

Hi @tomaszbarwicki a bit unsure will this also create the new one into our default docs/release directory currently GitHub shows me only the deletion of the file and not the move into different directory.

@tomaszbarwicki
Copy link
Contributor Author

Hi @tomaszbarwicki a bit unsure will this also create the new one into our default docs/release directory currently GitHub shows me only the deletion of the file and not the move into different directory.

@FaGru3n well spotted! fixed, thanks :)

Copy link
Contributor

@RoKrish14 RoKrish14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entry of dependabot.yml to trg-2-6 is not relevant. The updates related to dependabot are maintained under sig-security. Check 60.

@FaGru3n
Copy link
Contributor

FaGru3n commented Feb 13, 2024

The entry of dependabot.yml to trg-2-6 is not relevant. The updates related to deendabot are maintained under sig-security. Check 60.

Hi @RoKrish14 guess then we will need a separate TRG for Dependabot (how use it / and have it present for the release) here on our webpage that could link to your files within sig-security, but we have to make it clear that security is part of our TRG´s, but the hard requirements depend on your work.

So guess @tomaszbarwicki wants to create this TRG and if you also want to spread the word for security tools maybe we can discuss the place like moving dependapot to the Security related TRG´s under the umcomming point 8.

What do you think about that @tomaszbarwicki @RoKrish14 ?

@RoKrish14
Copy link
Contributor

I agree to the need of "moving dependapot to the Security related TRG´s under the upcomming point 8" and @klaudiaZF is in the process of creating the TRG 8.

@tomaszbarwicki
Copy link
Contributor Author

Hi @RoKrish14, I'm open to move it to security section when it gets created. Shall we pause the PR or park it temporarily in the GIT section?

@RoKrish14
Copy link
Contributor

@tomaszbarwicki : @klaudiaZF told me that your PR will go through with necessary changes. Once approved, it could be moved to TRG 8.0.
So, I would say, lets do that, lets focus on this PR about dependabot (Y). Later we can move it to TRG 8

@FaGru3n FaGru3n requested a review from RoKrish14 February 26, 2024 10:07
FaGru3n
FaGru3n previously approved these changes Feb 26, 2024
Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@klaudiaZF klaudiaZF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add npm and Gradle to yaml file and add information that open pull requests limits and interval can be set up based on team needs?

@RoKrish14
Copy link
Contributor

Can you add npm and Gradle to yaml file and add information that open pull requests limits and interval can be set up based on team needs?

This wont be necessary.
There are other options too that can be enabled based on use case.

@RoKrish14
Copy link
Contributor

Can you add npm and Gradle to yaml file and add information that open pull requests limits and interval can be set up based on team needs?

This wont be necessary. There are other options too that can be enabled based on use case.

@tomaszbarwicki and @FaGru3n :
I would suggest we could rephrase (as present in security_tooling.md) to inlude the other options.

"A basic example of a dependabot.yml file, demonstrating configurations for Docker and npm dependencies (all options), is shown below: "

@tomaszbarwicki
Copy link
Contributor Author

@klaudiaZF , @RoKrish14 incorporated your suggestions to add more dependabot config sample description informing about ability to customize certain parameters, included as well the link pointing to available ecosystem packages. Does that address your view? -> 666c60c

@RoKrish14
Copy link
Contributor

@klaudiaZF , @RoKrish14 incorporated your suggestions to add more dependabot config sample description informing about ability to customize certain parameters, included as well the link pointing to available ecosystem packages. Does that address your view? -> 666c60c

Yes, thanks a lot.

Copy link
Contributor

@RoKrish14 RoKrish14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks complete to me 👍

Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomaszbarwicki tomaszbarwicki merged commit 8443ef4 into main Mar 1, 2024
4 of 5 checks passed
@tomaszbarwicki tomaszbarwicki deleted the docs/publish_dependabot_trg branch March 1, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants