Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: DCM-Kit Content Release 24.03 #677

Merged
merged 23 commits into from
Mar 7, 2024
Merged

docs: DCM-Kit Content Release 24.03 #677

merged 23 commits into from
Mar 7, 2024

Conversation

nhaenis
Copy link
Contributor

@nhaenis nhaenis commented Feb 15, 2024

Description

  • What does this PR introduce? DCM-Kit Content for Releas 24.03
  • Does it fix a bug? Nope
  • Does it add a new feature? documentation only
  • Is it enhancing documentation? Yes, but for a new release

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@SebastianBezold SebastianBezold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There has been a decision and also communication, that we will publish openAPI specs on SwaggerHub and no longer have that on the website.

So please remove all openAPI related config + yaml files.
this will also maybe reduce the PR content to a level, that we do not have to create a project contribution check with the EF

@nhaenis
Copy link
Contributor Author

nhaenis commented Feb 22, 2024

There has been a decision and also communication, that we will publish openAPI specs on SwaggerHub and no longer have that on the website.

So please remove all openAPI related config + yaml files. this will also maybe reduce the PR content to a level, that we do not have to create a project contribution check with the EF

removed

@nhaenis
Copy link
Contributor Author

nhaenis commented Feb 23, 2024

@ reviewers: PR w/a finalized version of DCM guideline for solution adoption which is referenced in DCM arc42 - will be integraded asap, the rest of the content has been in our use case since last week without feedback, which should remain stable

Comment on lines 23 to 24
- Documentation Adoption View based on Catena-X release
- Documentation Development View based on Catena-X release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not really understand what "based on Catena-X release" means - would be nice if you could become a bit more concrete here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Described in more detail

@@ -11,6 +11,22 @@ sidebar_position: 1

All notable changes to this Kit will be documented in this file.

## [0.2.0] - 2024-02-xx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the date of the release: 2024-03-08

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

- **APIs** – to make sure that data are transmitted and consumed properly as well as are identically interpreted across companies. **Version 1.0.0** (Release 3.1) [CX-0048 DCM API Material Demand & Capacity Group](https://catena-x.net/de/standard-library)
- **Core Business logic** – to focus on a **common understanding** of the **DCM processes** among the participants. **Version 1.0.0** (Release 24.03) [CX-0128 Demand and Capacity Management Data Exchange](https://catena-x.net/de/standard-library)
- **Data model** – to align the structure of the shared data and enable the adoption of the core business logic without misinterpretation. **Version 1.0.0** (Release 24.03) [CX-0128 Demand and Capacity Management Data Exchange](https://catena-x.net/de/standard-library)
- **APIs** – to make sure that data are transmitted and consumed properly as well as are identically interpreted across companies. **Version 1.0.0** (Release 24.03) [CX-0128 Demand and Capacity Management Data Exchange](https://catena-x.net/de/standard-library)

### POWER of STANDARD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those statements really necessary as H3? Because they are showing up in the right navigation and we want to keep this as lean as possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to ** bold ** -> Linter error message can be ignored

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really an ARC42. This is more like high-level architecture. Can we change the title of this page to 'Architecture View'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


This document describes the `MaterialDemand`, `WeekBasedCapacityGroup`, `IdBasedRequestForUpdate` and `IdBasedComment` semantic models and the API definitions used in the DCM Catena-X network.

## ASPECT MODELS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use so much capital letters :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@danielmiehle
Copy link
Contributor

@nhaenis can you please fix the linting issues for the DCM KIT.

image

maximilianong
maximilianong previously approved these changes Feb 29, 2024
Copy link
Contributor

@maximilianong maximilianong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go for R 24.03, thanks @nhaenis

danielmiehle
danielmiehle previously approved these changes Mar 6, 2024
@nhaenis nhaenis dismissed stale reviews from danielmiehle and maximilianong via 14a828e March 6, 2024 07:53
@nhaenis
Copy link
Contributor Author

nhaenis commented Mar 6, 2024

@danielmiehle / @maximilianong resolved conflict - should be able to merge now

maximilianong
maximilianong previously approved these changes Mar 6, 2024
danielmiehle
danielmiehle previously approved these changes Mar 6, 2024
@maximilianong
Copy link
Contributor

There has been a decision and also communication, that we will publish openAPI specs on SwaggerHub and no longer have that on the website.

So please remove all openAPI related config + yaml files. this will also maybe reduce the PR content to a level, that we do not have to create a project contribution check with the EF

Please approve this - merging is blocked at the moment and we need to release this

- SPDX-FileCopyrightText: 2023,2023 Henkel AG & Co.KGaA
- SPDX-FileCopyrightText: 2023,2023 Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V (Fraunhofer)
- SPDX-FileCopyrightText: 2023,2023 Contributors to the Eclipse
- SPDX-FileCopyrightText: 2023-2024 ZF Friedrichshafen AG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright ranges are marked with , instead of -.

see Eclipse Foundation Project Handbook

SebastianBezold
SebastianBezold previously approved these changes Mar 7, 2024
Copy link
Contributor

@SebastianBezold SebastianBezold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, but the copyright year range should be fixed. Would be fine for me if this is done in a separate PR

See comment: https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/pull/677/files#r1515753997

Copy link
Contributor

@maximilianong maximilianong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nhaenis for adapting the changes.

@maximilianong maximilianong merged commit 2d24d22 into eclipse-tractusx:main Mar 7, 2024
4 of 5 checks passed
@nhaenis nhaenis deleted the dcm-content-r2403 branch March 7, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants