Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Knowledge Agents Kit: Linter and Version References Upped to 24.03 #704

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

drcgjung
Copy link
Contributor

Description

fixes linter issues. align version references with 24.03 assets. upgrade changelog. adapt copyright headers.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@drcgjung drcgjung requested a review from mhellmeier February 21, 2024 08:26
@drcgjung drcgjung added the bug Something isn't working label Feb 21, 2024
@drcgjung
Copy link
Contributor Author

since the other kits have not yet catched up, linting the overall thingy still does not work, but knowledge-agents errors are gone AFAICS

Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

Copy link
Contributor

@maximilianong maximilianong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@mhellmeier mhellmeier merged commit 20e24de into eclipse-tractusx:main Feb 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants