Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSim KIT 24.08 #962

Merged
merged 7 commits into from
Aug 2, 2024
Merged

Conversation

dominikoeh
Copy link
Contributor

Description

Added

  • Adoption View:
    • Added new Chapter Product documentation with a link to the document.

Changed

  • Adoption View:
    • Updated the aspect model references to the newest version.
  • Development View:
    • Updated the API descriptions in accordance with the newest OSim standardization document CX-133

Removed

  • Adoption View:
    • References to the obsolete OSim Standards.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@dominikoeh
Copy link
Contributor Author

/cc @theodorisinger

@dominikoeh
Copy link
Contributor Author

cc @jSchuetz88

danielmiehle
danielmiehle previously approved these changes Jul 23, 2024
Copy link
Contributor

@danielmiehle danielmiehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the new contributions and adaptions.

Copy link
Member

@jSchuetz88 jSchuetz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dominikoeh,

looks good to me, but please consider to update the APIs, as the openAPI plugin will be discontinued and the API and the respective MDX-files needs to be removed, please see the following guidance: #970

@maximilianong
Copy link
Contributor

Hi @dominikoeh can you please provide the API file as an .yaml

@dominikoeh
Copy link
Contributor Author

Hi @dominikoeh can you please provide the API file as an .yaml

@maximilianong API file as been added as .yaml

@jSchuetz88 jSchuetz88 requested a review from danielmiehle July 29, 2024 14:50
@stephanbcbauer
Copy link
Member

Discussed with @jSchuetz88 can be merged

@stephanbcbauer stephanbcbauer merged commit ab0e085 into eclipse-tractusx:main Aug 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants