Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/trx xxx upstream contribution #912

Conversation

ds-lcapellino
Copy link
Contributor

@ds-lcapellino ds-lcapellino commented Feb 3, 2025

Description

This PR introduces several contributions from Cofinity-X. A full List of contributions will follow.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

bmunguli and others added 30 commits September 2, 2024 15:18
(cherry picked from commit 32beedaff3a4db9a5ad3e2d72904bb70472e54f1)
…finity-docker-image-workflow

chore: [TRX-50] create docker image build workflow for cofinity image
Co-authored-by: ds-jhartmann <[email protected]>
Co-authored-by: Avishek Pathania (Cofinity-X) <[email protected]>
Co-authored-by: ds-awahl <[email protected]>
* explicity pass github token to swagger-ui-action
ds-lcapellino and others added 19 commits November 28, 2024 15:36
Co-authored-by: maciej.kizlich <[email protected]>
Co-authored-by: Jaro Hartmann <[email protected]>
# Conflicts:
#	.github/workflows/cucumber-integration-test-UMBRELLA.yaml
#	.github/workflows/publish-documentation.yaml
#	.github/workflows/tavern-UMBRELLA.yml
#	CHANGELOG.md
#	DEPENDENCIES
#	irs-edc-client/src/main/java/org/eclipse/tractusx/irs/edc/client/asset/EdcAssetService.java
#	irs-edc-client/src/main/java/org/eclipse/tractusx/irs/edc/client/policy/ConstraintCheckerService.java
#	irs-edc-client/src/test/java/org/eclipse/tractusx/irs/edc/client/EdcOrchestratorTest.java
#	irs-edc-client/src/test/java/org/eclipse/tractusx/irs/edc/client/asset/EdcAssetServiceTest.java
#	pom.xml
…am-contribution

# Conflicts:
#	CHANGELOG.md
#	irs-edc-client/src/main/java/org/eclipse/tractusx/irs/edc/client/policy/ConstraintCheckerService.java
#	irs-edc-client/src/test/java/org/eclipse/tractusx/irs/edc/client/EdcOrchestratorTest.java
#	irs-load-tests/pom.xml
@@ -142,8 +153,9 @@
echo "$EOF" >> "$GITHUB_ENV"

- name: Update docs and Helm chart for release
uses: peter-evans/create-pull-request@v6
uses: peter-evans/create-pull-request@v7

Check notice

Code scanning / KICS

Unpinned Actions Full Length Commit SHA Note

Action is not pinned to a full length commit SHA.
private static final String BASE_URL = System.getenv("IRS_HOST");
private static final Boolean ASSETS_WITH_CHILDS = Boolean.valueOf(System.getenv("ASSETS_WITH_CHILDS"));
private static final String X_API_KEY = System.getenv("API_KEY");
private static final Integer SCENARIO_DURATION = Integer.valueOf(System.getenv("SCENARIO_DURATION"));

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note test

Potential uncaught 'java.lang.NumberFormatException'.
public class OrderSimulation extends Simulation {

private static final String BASE_URL = System.getenv("IRS_HOST");
private static final Integer SCENARIO_DURATION = Integer.valueOf(System.getenv("SCENARIO_DURATION"));

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note test

Potential uncaught 'java.lang.NumberFormatException'.
@ds-lcapellino
Copy link
Contributor Author

Eclipse IP Team accepted the PR: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/19278

Copy link
Contributor

@ds-mwesener ds-mwesener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-lcapellino ds-lcapellino merged commit 6d75b59 into eclipse-tractusx:main Feb 6, 2025
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants