Skip to content

Commit

Permalink
fix(docker): Do not alter base image packages by calling apt upgrade/…
Browse files Browse the repository at this point in the history
…apt update. Instead let trivy scan results always proceed.
  • Loading branch information
drcgjung committed Nov 20, 2023
1 parent 5b0186c commit 41e036d
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/trivy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
with:
scan-type: "config"
# ignore-unfixed: true
exit-code: "1"
exit-code: "0"
hide-progress: false
format: "sarif"
output: "trivy-results-config.sarif"
Expand Down Expand Up @@ -126,7 +126,7 @@ jobs:
image-ref: "${{ steps.set-docker-repo.outputs.REPO }}/${{ matrix.image }}:${{ needs.git-sha7.outputs.value }}"
format: "sarif"
output: "trivy-results-${{ matrix.image }}.sarif"
exit-code: "1"
exit-code: "0"
severity: "CRITICAL,HIGH"
timeout: "10m0s"

Expand Down
2 changes: 0 additions & 2 deletions agent-plane/agentplane-azure-vault/src/main/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ ARG APP_USER=docker
ARG APP_UID=10100
ARG APP_GID=30000

RUN apk update && apk upgrade libssl3 libcrypto3 --no-cache

RUN addgroup --gid "$APP_GID" --system "$APP_USER"

RUN adduser \
Expand Down
2 changes: 0 additions & 2 deletions agent-plane/agentplane-hashicorp/src/main/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ ARG APP_USER=docker
ARG APP_UID=10100
ARG APP_GID=30000

RUN apk update && apk upgrade libssl3 libcrypto3 --no-cache

RUN addgroup --gid "$APP_GID" --system "$APP_USER"

RUN adduser \
Expand Down

0 comments on commit 41e036d

Please sign in to comment.