Feature/97 matchmaking agent api #104
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is mostly a migration/carveout of code from https://github.com/eclipse-tractusx/knowledge-agents-edc/tree/main/agent-plane/agent-plane-protocol/src/main/java/org/eclipse/tractusx/agents/edc into a new servlet container (glassfish) together with some EDC client stubs (to render it independent of EDC).
It represents a new product/chart which provides external agent functionality (SPARQL engine, federated catalogue) independent of EDC (data plane) such that it can be used to host business data as well without being exposed to the dataspace/public internet.
As such it represents a big advantage for security architecture.
Copyright attachments and dependencies have been rechecked, such that no fresh IP check needs to made.
.github/workflows/build.yml
Outdated
| type=semver,pattern={{version}} | ||
| type=semver,pattern={{major}} | ||
| type=semver,pattern={{major}}.{{minor}} | ||
| type=raw,value=1.10.15-SNAPSHOT,enable=${{ github.event.inputs.deploy_docker == 'true' || github.ref == format('refs/heads/{0}', 'main') }} |
charts/matchmaking-agent/.helmignore
Outdated
| @@ -0,0 +1,45 @@ | |||
| # Copyright (c) 2022,2023 Contributors to the Eclipse Foundation | |||
There was a problem hiding this comment.
need to adapt copyright period.
|
|
||
| RUN addgroup --gid "$APP_GID" --system "$APP_USER" | ||
|
|
||
| RUN apk add --update curl |
There was a problem hiding this comment.
Based on this TRG it is discouraged to modify a base image like this. It would make the image scan and package list provided by DockerHub unusable.
There was a problem hiding this comment.
will be resolved. Thx for the heads up. Martin used curl instead of wget for testing on his machine and commited the change unfortunately.
|
Hey, I would also suggest implementing the dependencies workflow to have an automated check on each PR like here. This would make sure that we don't merge PRs that have outdated DEPENDENCIES files. Also can you clarify here how the dependencies work in this repo? Are they consolidated into a single file? |
…hmaking dockerfile compliant to the TRG
Hi @drcgjung, even though it is a migration, an IP check is necessary as the contribution is coming from catenax-ng and the number of line changes are way above 1000. See TRG7.03 for more info. |
I would agree if you would have had smaller and more focused PRs doing clearly only one thing and not multiply things. Or if you would have developed this IN eclipse-tractusx (a branch) and not from an outside repository. This definitly needs an IP check and proper procedure |
|
I've opened the IP ticket, you can it's track the progress here. |
|
Regarding the warning for the |
will do |
I though so. Yes, lets do an IP check on the patch text. |
WHAT
This container separates the Matchmaking Agent's functionality from the Agent Plane Container. As a result, the RDF Store is disjoined from the public-facing Agent Plane container.
WHY
It caters for the need of small and medium sized companies who want to directly upload/provide use case data as well as for security-aware companies who want to separate data storage from public API even for meta-data. This container also has the ability to be used by the Simple Graph Exchanger Feature, adding the ability to host business data from the RDF Store over the Matchmaking Agent Communication between the Agent Plane Container and the Matchmaking Agent by a REST API on the docker (internal) network.
FURTHER NOTES
To make use of the matchmaking agent set the right dataplane.properties settings in tx-knowledge-agents-edc (agent-plane-protocol)
Closes #
Feature97