Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adjust policy hub docu #56

Merged
merged 1 commit into from
Feb 29, 2024
Merged

chore: adjust policy hub docu #56

merged 1 commit into from
Feb 29, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Feb 27, 2024

Description

Adjust documentation of the policy hub

Why

To give the user a good overview of the policy hub

Issue

N/A

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

evegufy
evegufy requested changes Feb 27, 2024
View reviewed changes
docs/static/whitebox-overall-system.png Outdated Show resolved Hide resolved
@Phil91 Phil91 requested a review from evegufy February 27, 2024 10:15
evegufy
evegufy requested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, could you please still change to latest state of the diagram regarding labels and move the requests?

@Phil91 Phil91 force-pushed the feature/documenation branch 2 times, most recently from e2ef3c6 to d7597c1 Compare February 29, 2024 09:37
@Phil91 Phil91 requested a review from evegufy February 29, 2024 09:38
@Phil91
Copy link
Member Author

Phil91 commented Feb 29, 2024

as discussed, could you please still change to latest state of the diagram regarding labels and move the requests?

@evegufy done

@Phil91 Phil91 mentioned this pull request Feb 29, 2024
Merged
1 task
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Phil91 Phil91 merged commit c7aefe8 into release/v0.1.0-rc.4 Feb 29, 2024
7 checks passed
@Phil91 Phil91 deleted the feature/documenation branch February 29, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evegufy evegufy evegufy approved these changes

@jjeroch jjeroch Awaiting requested review from jjeroch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Phil91 @evegufy