Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enhance bpdm interface documentation #237

Conversation

jjeroch
Copy link
Contributor

@jjeroch jjeroch commented Jan 26, 2024

Description

Adjusted BPDM interface contract documentation

Why

Changes in the interface implementation as well as correction of incorrect mentioned details

Issue

n/a

Checklist

@jjeroch jjeroch requested a review from Phil91 January 26, 2024 22:42
@@ -230,7 +231,7 @@ The call itself is not a API triggered call but automated by the process worker.
However the administrator of the platform has the chance to retrigger the process in the scenario of an failure.

```diff
! POST /api/administration/registration/application/{applicationId}/trigger-bpn
! GET /api/catena/sharing-state
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Phil91 in this section we need to add the additional endpoint details of the second called endpoint to retrieve the BPN ++ can you please explain shortly inside the interface contract why we call 2 endpoints? Thanks!

@Phil91 Phil91 changed the title Enhance/bpdm interface documentation chore: enhance bpdm interface documentation Jan 29, 2024
Copy link
Member

@Phil91 Phil91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. @jjeroch do you want to double check?

@evegufy evegufy changed the base branch from release/v1.8.0-RC3 to elease/v1.8.0-RC4 January 31, 2024 14:24
@evegufy evegufy changed the base branch from elease/v1.8.0-RC4 to release/v1.8.0-RC4 January 31, 2024 15:47
@evegufy evegufy force-pushed the enhance/bpdm-interface-documentation branch from 90045a6 to 149bb36 Compare February 13, 2024 16:59
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflict resolved

@evegufy evegufy merged commit 532a127 into eclipse-tractusx:release/v1.8.0-RC4 Feb 13, 2024
6 checks passed
@evegufy evegufy deleted the enhance/bpdm-interface-documentation branch February 13, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants