feat(sd): add process steps for sd creation #1189
Conversation
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Phil91
force-pushed
the
feature/1182-sd
branch
2 times, most recently
from
64c6989 to
25f04c3
Compare
| { | ||
| con.SelfDescriptionMessage = data.Message!; | ||
| con.DateLastChanged = DateTimeOffset.UtcNow; | ||
| }); | ||
| } | ||
|
|
||
| var processData = await connectorsRepository.GetProcessDataForConnectorId(data.ExternalId); | ||
| if (processData == null) |
There was a problem hiding this comment.
this check processData == null guarantees that the subsequent call to CreateManualProcessData will throw NorFoundException. I suspect this is not intended ;-)
| } | ||
|
|
||
| var processData = await companyRepository.GetProcessDataForCompanyIdId(data.ExternalId); | ||
| if (processData == null) |
There was a problem hiding this comment.
same here - checking processData == null seems to be incorrect.
ntruchsess
force-pushed
the
feature/1182-sd
branch
from
b90b40c to
c7b1da6
Compare
There was a problem hiding this comment.
In my previous review I mention 2 null checks that seem to be incorrect. I've fixed those but apparently this is not covered by unit-tests. Can you please double check and add respective test-code for those null-checks?
Please be aware that I did rebase and recreate the migration.
| if (context.ProcessStepTypeId.HasValue) | ||
| { | ||
| context.ProcessRepositories.GetInstance<IProcessStepRepository<TProcessTypeId, TProcessStepTypeId>>().AttachAndModifyProcessSteps( | ||
| ModifyStepStatusRange(context.ProcessSteps.Where(step => step.ProcessStepTypeId.Equals(context.ProcessStepTypeId.Value)), ProcessStepStatusId.FAILED, message)); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
Phil91
force-pushed
the
feature/1182-sd
branch
from
3b7db37 to
8eedda1
Compare
tests/externalsystems/SdFactory.Library.Tests/SdFactoryBusinessLogicTests.cs
Fixed
Show fixed
Hide fixed
tests/externalsystems/SdFactory.Library.Tests/SdFactoryBusinessLogicTests.cs
Fixed
Show fixed
Hide fixed
tests/externalsystems/SdFactory.Library.Tests/SdFactoryBusinessLogicTests.cs
Fixed
Show fixed
Hide fixed
|
* feat(sd): add process steps for sd creation + retrigger * update framework minor version * add and adjust unit tests Refs: #1182 --------- Co-authored-by: Norbert Truchsess <[email protected]>
* feat(sd): add process steps for sd creation + retrigger * update framework minor version * add and adjust unit tests Refs: #1182 --------- Co-authored-by: Norbert Truchsess <[email protected]>
Description
Why
To be able to display the current progress of the sd document recreation a await step has been added for the self description creation process
Issue
Refs: #1182
Checklist