Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Auto-setup): added auth details in auto setup api #1232

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

dhiren-singh-007
Copy link
Contributor

@dhiren-singh-007 dhiren-singh-007 commented Jan 9, 2025

Description

  1. Added auth details in auto setup creat/update api
  2. Created new api to delete the auto setup configuration

Why

All customer have to share same authentication details for auto setup from central idp

Issue

#1151

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines-
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes

@dhiren-singh-007 dhiren-singh-007 marked this pull request as ready for review January 10, 2025 15:45
@dhiren-singh-007
Copy link
Contributor Author

Sorry for the multiple commits. Somehow my local machine was showing everything successful, but later it got failed in PR checks

@MaximilianHauer MaximilianHauer requested review from Phil91, evegufy and ntruchsess and removed request for Phil91 January 15, 2025 07:44
@MaximilianHauer MaximilianHauer added this to the Release 25.03 milestone Jan 15, 2025
@MaximilianHauer
Copy link

@dhiren-singh-007 please ensure to set the milestone of the PR based on the config in your issue

@dhiren-singh-007 dhiren-singh-007 force-pushed the bugfix/1151_auth_auto_setup branch from d63d395 to ff1a041 Compare January 27, 2025 04:58
@dhiren-singh-007
Copy link
Contributor Author

@Phil91 @evegufy : Do you know what could be issue in the pipeline ,dotnet build and test is running fine on my local. Can you please check?

@Phil91
Copy link
Member

Phil91 commented Jan 27, 2025

@Phil91 @evegufy : Do you know what could be issue in the pipeline ,dotnet build and test is running fine on my local. Can you please check?

@dhiren-singh-007 sometimes the build fails due to a failing dotnet tool restore / install which is needed for the build. I've retriggered it.

/cc @evegufy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants