feat(companyData): enhance GET: /api/administration/companyData/missing-sd-document

[Phil91]

Description

Add SdSkipped Date to GET: /api/administration/companyData/missing-sd-document

Why

To get an overview when the process was skipped

Issue

Refs: #1179

Checklist

• I have followed the contributing guidelines
• I have performed IP checks for added or updated 3rd party libraries
• I have created and linked IP issues or requested their creation by a committer
• I have performed a self-review of my own code
• I have successfully tested my changes locally
• I have added tests that prove my changes work
• I have checked that new and existing tests pass locally with my changes
• I have commented my code, particularly in hard-to-understand areas

[ntruchsess]

I did suggest a refactored query that should translate into the expected sql, but I suspect the data that is being selected is actually not correct as there is no guarantee that skipped process-steps refer to the most recent process-activity of the respective process. (In case a process is retriggered the previously created processStep instances in status skipped will just stay while a new processStep in status TODO is being created).

[ntruchsess]

this check is redundant - the expression translates into sql. On the database the selected column-value is just null in case the join of a table itself has no results.
Actually I'm surprised the corresponding test runs without error. I suspect this doesn't compile into SQL but runs on client-side. (the called static method also contains syntax that would not compile as the 'is' keyword is not supported within an expression).

[Phil91]

seems like if one uses an method for the expression generation the check isn't working correctly. As soon as I moved the expression back to the origin I saw a warning.

[ntruchsess]

as according to the database-schema there could be multiple matches just selecting the first without enforcing a specific order will eventually return an incorrect result.

[Phil91]

added the orderBy

[ntruchsess]

this condition is redundant to the Where-condition within the SelectMany. As this should compile into SQL (which I suppose it doesn't anyway) it will just create more complicated SQL with no runtime benefit.

[ntruchsess]

Suggested change

	GetCompanyLastChangeDate(c)!.DateLastChanged)
	).SingleOrDefaultAsync();
	private static ProcessStep? GetCompanyLastChangeDate(Company company) => company.CompanyApplications.Where(ca =>
	ca.ApplicationChecklistEntries.Any(a =>
	a.ApplicationChecklistEntryTypeId == ApplicationChecklistEntryTypeId.SELF_DESCRIPTION_LP &&
	a.ApplicationChecklistEntryStatusId != ApplicationChecklistEntryStatusId.SKIPPED) &&
	ca.ChecklistProcess!.ProcessSteps.Any(ps =>
	ps is
	{
	ProcessStepTypeId: ProcessStepTypeId.START_SELF_DESCRIPTION_LP,
	ProcessStepStatusId: ProcessStepStatusId.SKIPPED
	}))
	.SelectMany(ca => ca.ChecklistProcess!.ProcessSteps.Where(ps =>
	ps is
	{
	ProcessStepTypeId: ProcessStepTypeId.START_SELF_DESCRIPTION_LP,
	ProcessStepStatusId: ProcessStepStatusId.SKIPPED
	})).FirstOrDefault();
	c.CompanyApplications
	.Where(ca =>
	ca.ApplicationChecklistEntries.Any(a =>
	a.ApplicationChecklistEntryTypeId == ApplicationChecklistEntryTypeId.SELF_DESCRIPTION_LP &&
	a.ApplicationChecklistEntryStatusId != ApplicationChecklistEntryStatusId.SKIPPED))
	.SelectMany(ca =>
	ca.ChecklistProcess!.ProcessSteps.Where(ps =>
	ps.ProcessStepTypeId == ProcessStepTypeId.START_SELF_DESCRIPTION_LP &&
	ps.ProcessStepStatusId == ProcessStepStatusId.SKIPPED))
	.OrderByDescending(ps => ps.DateLastChanged)
	.FirstOrDefault()!.DateLastChanged)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud