Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations): add custom history repository #1263

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Feb 6, 2025

Description

  • add custom history repository

Why

To overwrite the implementation of Npgsql which is skipping the existing check of the migration table, which leads to an error in our implementation, since the migration history tables are located in the public schema. Since the portal and provisioning user don't have the create grant the create if not existsstatement of the nuget package fails.

Issue

Refs: #1262

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 requested review from evegufy and ntruchsess February 6, 2025 14:50
@Phil91 Phil91 force-pushed the bugfix/1262-migrations branch 4 times, most recently from 4ce2d20 to c501f57 Compare February 6, 2025 15:06
@Phil91 Phil91 force-pushed the bugfix/1262-migrations branch from c501f57 to 12338b9 Compare February 6, 2025 15:16
@evegufy evegufy added this to the Release 25.03 milestone Feb 6, 2025
Copy link

sonarqubecloud bot commented Feb 6, 2025

@Phil91 Phil91 merged commit 05c0f61 into main Feb 6, 2025
12 checks passed
@Phil91 Phil91 deleted the bugfix/1262-migrations branch February 6, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants