Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(versioning): add versioning to apis #367

Closed
wants to merge 1 commit into from
Closed

feat(versioning): add versioning to apis #367

wants to merge 1 commit into from

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Dec 1, 2023 •
edited
Loading

Description

This PR is intended to be an example of how to provide api versioning to the apis of the portal backend

Why

To support multiple api versions

Issue

#292

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 force-pushed the feature/CPLP-1936-api-version branch 2 times, most recently from 295efac to fdd4448 Compare December 1, 2023 10:36
@Phil91 Phil91 requested review from ntruchsess and evegufy and removed request for ntruchsess December 1, 2023 10:36
@Phil91
Copy link
Member Author

Phil91 commented Dec 1, 2023

@ntruchsess , @evegufy i created the pr as a discussion base for the api versioning. if you find some time please have a look at it. we could also have a shared meeting where i can show you what i changed and how swagger behaves with the new versioning.

@Phil91 Phil91 force-pushed the feature/CPLP-1936-api-version branch from fdd4448 to 3c85ab5 Compare December 1, 2023 10:49
@evegufy
Copy link
Contributor

evegufy commented Dec 5, 2023

@Phil91 we need to discuss this change with the frontend, as this is a breaking change. We also need to review the helm-chart in portal-cd if there a changes needed.

@Phil91 Phil91 added the breaking change PR shall be handled with extra care as it breaks existing functionality label Dec 5, 2023
@Phil91 Phil91 force-pushed the feature/CPLP-1936-api-version branch 2 times, most recently from 203f7f1 to a0135b2 Compare December 11, 2023 08:02
@jjeroch jjeroch mentioned this pull request Dec 11, 2023
Open
1 task
@Phil91 Phil91 force-pushed the feature/CPLP-1936-api-version branch from a0135b2 to 33e72b7 Compare December 11, 2023 13:50
@Phil91 Phil91 force-pushed the feature/CPLP-1936-api-version branch from 33e72b7 to 218706e Compare December 11, 2023 13:51
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
2.0% 2.0% Duplication

@jjeroch jjeroch added this to the Version CX Release 24.05 (dev) milestone Feb 4, 2024
@evegufy evegufy changed the base branch from dev to change-to-main June 21, 2024 14:07
@evegufy evegufy changed the base branch from change-to-main to main June 21, 2024 15:33
@catenax-ng catenax-ng closed this by deleting the head repository Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evegufy evegufy Awaiting requested review from evegufy

@ntruchsess ntruchsess Awaiting requested review from ntruchsess

Assignees
No one assigned
Labels
breaking change PR shall be handled with extra care as it breaks existing functionality
Projects
None yet
Milestone
Release 2.0.0 (24.05)
Development

Successfully merging this pull request may close these issues.
4 participants
@Phil91 @evegufy @jjeroch @catenax-ng