Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update useEffect dependency, handleChange #280

Merged

Conversation

shubhamv-ss
Copy link
Contributor

@shubhamv-ss shubhamv-ss commented Aug 23, 2024

Description

Screen.Recording.2024-08-23.at.12.22.58.PM.mov
Screen.Recording.2024-08-23.at.12.05.29.PM.mov

Why

  • By using JSON.stringify(defaultValue), we create a new string representation of the object on every render. When the properties of the object change, the string representation also changes, which triggers the effect to be re-run.
  • The value should clear when clicking on the X button in the <SelectList /> component.
  • I tested this component by copying all the files related to <SelectList /> in the local for the Connector Registration and theApp Realease Process step 1.

Issue

Checklist

Please delete options that are not relevant.

  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@shubhamv-ss shubhamv-ss marked this pull request as ready for review August 23, 2024 12:12
@shubhamv-ss
Copy link
Contributor Author

Hi @evegufy , Could you check this PR?

@typecastcloud
Copy link
Contributor

Hi @MaximilianHauer, can you please check the second video here. This might be an issue that you notice when running tests on connector registration.

Shubham is on a break right now but I have access to his fork.

CC: @saadanzari

@MaximilianHauer
Copy link

MaximilianHauer commented Sep 6, 2024

@typecastcloud thx that's exactly what i experienced :)

topic i raised

related PR

@oyo / @lavanya-bmw can you please align how to continue on this topic as we have now two drifferent PR

Copy link

@oyo oyo changed the title fix: update useeffect dependancy, handleChange fix: update useEffect dependency, handleChange Sep 11, 2024
@oyo oyo merged commit aac007d into eclipse-tractusx:main Sep 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

4 participants