-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update useEffect dependency, handleChange #280
fix: update useEffect dependency, handleChange #280
Conversation
Hi @evegufy , Could you check this PR? |
Hi @MaximilianHauer, can you please check the second video here. This might be an issue that you notice when running tests on connector registration. Shubham is on a break right now but I have access to his fork. CC: @saadanzari |
@typecastcloud thx that's exactly what i experienced :) topic i raised related PR @oyo / @lavanya-bmw can you please align how to continue on this topic as we have now two drifferent PR |
Quality Gate passedIssues Measures |
Description
<SelectList/>
component caused by my previous changes on theConnector Registration
screen.Screen.Recording.2024-08-23.at.12.22.58.PM.mov
Screen.Recording.2024-08-23.at.12.05.29.PM.mov
Why
JSON.stringify(defaultValue)
, we create a new string representation of the object on every render. When the properties of the object change, the string representation also changes, which triggers the effect to be re-run.X
button in the<SelectList />
component.<SelectList />
in the local for theConnector Registration
and theApp Realease Process
step 1.Issue
Checklist
Please delete options that are not relevant.