Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/partner sitebpns #27

Merged

Conversation

eschrewe
Copy link
Contributor

Description

Refactored the Partner entity to allow inclusion of BPNA under the Partner's BPNL as well as under Sites's BPNS.
The local instance of the PURIS backend now allows/requires extended configuration with regard to it's owners data.

Pre-review checks

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort. Please rerun the dependency check accordingly, change findAny to findFirst and add some documentation to the heavier constructors

@eschrewe eschrewe mentioned this pull request Aug 30, 2023
2 tasks
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please switch to findFirst and include test scope for dependencies file.

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks a lot and great effort!

@tom-rm-meyer-ISST
Copy link
Contributor

@mhellmeier Quality Check problem has been reported yesterday. From my side, ready for merge.

Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhellmeier mhellmeier merged commit b617b26 into eclipse-tractusx:main Sep 8, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants