-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/partner sitebpns #27
Refactor/partner sitebpns #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great effort. Please rerun the dependency check accordingly, change findAny to findFirst and add some documentation to the heavier constructors
backend/src/main/java/org/eclipse/tractusx/puris/backend/DataInjectionCommandLineRunner.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/DataInjectionCommandLineRunner.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/tractusx/puris/backend/common/api/logic/service/VariablesService.java
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/masterdata/domain/model/Address.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/masterdata/domain/model/Partner.java
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/masterdata/domain/model/Site.java
Show resolved
Hide resolved
...ain/java/org/eclipse/tractusx/puris/backend/masterdata/logic/service/PartnerServiceImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please switch to findFirst and include test scope for dependencies file.
backend/src/main/java/org/eclipse/tractusx/puris/backend/DataInjectionCommandLineRunner.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/DataInjectionCommandLineRunner.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, thanks a lot and great effort!
@mhellmeier Quality Check problem has been reported yesterday. From my side, ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Refactored the Partner entity to allow inclusion of BPNA under the Partner's BPNL as well as under Sites's BPNS.
The local instance of the PURIS backend now allows/requires extended configuration with regard to it's owners data.
Pre-review checks