fix: Runtime issue of ShellRepository.findByIdExternalAndExternalSubjectId() #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
With a growing number of shells registered ShellRepository.findByIdExternalAndExternalSubjectId() has an exponentially growing run time when accessed by a different one than the owning tenant id.
Solution:
The fix replaces the expensive IN statement in the WHERE clause of the backing SQL command by a much more cheaper EXISTS statement.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: