Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Runtime issue of ShellRepository.findByIdExternalAndExternalSubjectId() #265

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

sm29105
Copy link

@sm29105 sm29105 commented Dec 12, 2023

Issue:
With a growing number of shells registered ShellRepository.findByIdExternalAndExternalSubjectId() has an exponentially growing run time when accessed by a different one than the owning tenant id.

Solution:
The fix replaces the expensive IN statement in the WHERE clause of the backing SQL command by a much more cheaper EXISTS statement.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gerbigf
Copy link

gerbigf commented Dec 12, 2023

@thomas-henn, FYI. The issue of exponential runtime really blocked and blocks us in our go-live preparations. Please review the PR and provide feedback to us!

@sm29105
Copy link
Author

sm29105 commented Dec 12, 2023

Note. After a hint from @gerbigf I now also signed the ECA from the Eclipse Foundation.

Copy link
Contributor

@tunacicek tunacicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tunacicek tunacicek merged commit 80d8cd7 into eclipse-tractusx:main Dec 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants