Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ci analysis for sonar #337

Merged
merged 17 commits into from
Mar 28, 2024
Merged

chore: add ci analysis for sonar #337

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d68fc21
ci: add ci analysis for sonar cloud
bmunguli Feb 21, 2024
b692ef4
refactor: add spaces between steps in workflow
bmunguli Feb 21, 2024
bd79bf0
chore: remove extra empty lines
bmunguli Mar 4, 2024
28e3a45
chore: add sonar project name
bmunguli Mar 5, 2024
1b45bda
fix: pass project key as part of the task instead in pom.xml
bmunguli Mar 5, 2024
a08c700
fix: add sonar properties as part of the cli task
bmunguli Mar 8, 2024
0afbbf0
fix: remove redudant argument
bmunguli Mar 8, 2024
01a8ca8
chore: add debugging option to help identify the sonar task
bmunguli Mar 8, 2024
9e3ba02
chore: access sonar organization and key from repository varuables
bmunguli Mar 11, 2024
60aa458
chore: remove module key configuration
bmunguli Mar 12, 2024
7c7e7fe
chore: bring back moduleKey configuration needed by multimodule projects
bmunguli Mar 12, 2024
c3ae786
ci: revert back to hardcoded values
bmunguli Mar 12, 2024
a000a90
Merge branch 'main' into ci/Add-sonarcloud-ci-analysis
bmunguli Mar 28, 2024
aaabb26
fix: remove sonar cloud steps from build workflow
bmunguli Mar 28, 2024
aa13265
ci: add dedicated workflow for running sonar on schedule and main branch
bmunguli Mar 28, 2024
1490f77
chore: clean up unused variable.
bmunguli Mar 28, 2024
090c1ff
chore: remove empty line
bmunguli Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/build-snapshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,28 @@ jobs:
packages: write
steps:
- uses: actions/checkout@v3

- name: Set up JDK 17
uses: actions/setup-java@v3
with:
java-version: '17'
distribution: 'adopt'
cache: maven

- name: Cache SonarCloud packages
uses: actions/cache@v4
with:
path: ~/.sonar/cache
key: ${{ runner.os }}-sonar
restore-keys: ${{ runner.os }}-sonar

- name: Build and Deploy with Maven
run: mvn clean -X install
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: SonarCloud Code Analysis
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
run: mvn -B verify --batch-mode sonar:sonar
32 changes: 32 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,20 @@
<!-- test libs -->
<assertj.version>3.24.2</assertj.version>
<junit.version>5.9.3</junit.version>
<jacoco.version>0.8.11</jacoco.version>

<!-- sonar plugin -->
<sonar-maven-plugin.version>3.10.0.2594</sonar-maven-plugin.version>


<!-- build -->
<maven.compiler.version>3.8.1</maven.compiler.version>


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the second empty line, one empty line should be enough.

<!-- Sonar related properties -->
<sonar.organization>eclipse-tractusx</sonar.organization>
<sonar.projectKey>eclipse-tractusx_sldt-digital-twin-registry</sonar.projectKey>
<sonar.host.url>https://sonarcloud.io</sonar.host.url>
</properties>

<modules>
Expand Down Expand Up @@ -405,6 +416,27 @@
</plugin>
</plugins>
</pluginManagement>
<plugins>
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<version>${jacoco.version}</version>
<executions>
<execution>
<goals>
<goal>prepare-agent</goal>
</goals>
</execution>
<execution>
<id>report</id>
<phase>test</phase>
<goals>
<goal>report</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>

<repositories>
Expand Down
Loading