Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(seeding): make authorities bpn configurable via helm chart #80

Merged
merged 4 commits into from
Nov 11, 2024
Merged

feat(seeding): make authorities bpn configurable via helm chart #80

merged 4 commits into from
Nov 11, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Oct 22, 2024 •
edited by evegufy
Loading

Description

  • make authority and credential authorities bpn configurable via helm chart

BEGIN_COMMIT_OVERRIDE
feat(seeding): make authorities bpn configurable via helm chart
END_COMMIT_OVERRIDE

Why

To enable dynamic seeding for authorities bpn - currently two authorities can be configured, this should mainly support the testing playground/sandbox use case where the configurability of the (two) authorities could support not having to build an ad hoc image

Issue

Refs: #77

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 requested a review from evegufy October 22, 2024 05:39
@Phil91
feat(seeding): adjust config for seeding data
eb3496e 
* make authority and credential authorities for operator overwriteable
* add configuration to add own config maps for seeding

Refs: #77
@Phil91 Phil91 force-pushed the feature/77-seeding branch from 0954e9b to eb3496e Compare October 22, 2024 06:09
evegufy
evegufy requested changes Oct 24, 2024
View reviewed changes
charts/ssi-asr/values.yaml Outdated Show resolved Hide resolved
@Phil91 Phil91 requested a review from evegufy November 8, 2024 12:15
@Phil91 Phil91 force-pushed the feature/77-seeding branch from c8389e6 to ad65e66 Compare November 8, 2024 12:41
@Phil91 Phil91 force-pushed the feature/77-seeding branch from ad65e66 to 5061f07 Compare November 8, 2024 12:46
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Phil91 Phil91 merged commit 020d4b7 into main Nov 11, 2024
11 checks passed
@Phil91 Phil91 deleted the feature/77-seeding branch November 11, 2024 13:26
@evegufy evegufy changed the title feat(seeding): adjust config for seeding data feat(seeding): make authorities bpn configurable via helm chart Nov 11, 2024
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evegufy evegufy evegufy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 1.1.0 (24.12)
Development

Successfully merging this pull request may close these issues.
2 participants
@Phil91 @evegufy