Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make statuslist type configureable #298

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Nov 12, 2024

Description

The statuslist type used for the credentials is now configureable

Why

Since the currently used type for the status list (Statuslist2021) was hardcoded the type used in the credentials for the status list is now configureable to be able to use the BitstringStatusList

Issue

Refs: #299

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 requested a review from evegufy November 12, 2024 14:31
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helm install fails, could you please check?

As #224 contains a lot of different information, could you please create an own issue for that, similar to this one #226?

@Phil91 Phil91 force-pushed the feature/224-statuslist branch from 8bdf822 to cc757fc Compare November 13, 2024 11:16
@evegufy evegufy added the merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled label Nov 13, 2024
@MaximilianHauer
Copy link
Contributor

@evegufy how do we proceed based on the last SSI EG meeting ?

@evegufy
Copy link
Contributor

evegufy commented Feb 5, 2025

@evegufy how do we proceed based on the last SSI EG meeting ?

we still go ahead with the change, as it just enable configurability and the config default to statuslist2021

@evegufy evegufy removed the merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled label Feb 5, 2025
@Phil91 Phil91 merged commit b2445f5 into main Feb 5, 2025
11 checks passed
@Phil91 Phil91 deleted the feature/224-statuslist branch February 5, 2025 14:43
leandro-cavalcante pushed a commit to leandro-cavalcante/ssi-credential-issuer that referenced this pull request Feb 5, 2025
leandro-cavalcante pushed a commit to leandro-cavalcante/ssi-credential-issuer that referenced this pull request Feb 5, 2025
leandro-cavalcante pushed a commit to leandro-cavalcante/ssi-credential-issuer that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants