-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/edc 0.7.0 iatp mock #101
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
cd4a335
to
7045b61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Just some comments and when installing locally with dataexchange subset, I encounter the following issue:
Error: INSTALLATION FAILED: execution error at (umbrella/charts/tx-data-provider/charts/tractusx-connector/templates/deployment-controlplane.yaml:302:75): .Values.backendService.httpProxyTokenReceiverUrl is required
|
||
in case of enabling `iatpmock` (e.g. by using [values-adopter-data-exchange.yaml](values-adopter-data-exchange.yaml)), the iatp-mock docker image must be built first: | ||
|
||
`docker build iatp-mock/ -t tractusx/iatp-mock:testing --platform linux/amd64` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should discuss if it's not worth to also publish the image, for e2e testing maybe not necessary but from a local sandbox (easy entrance point for new developers) maybe beneficial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's something I don't like either. The mock requires configuration in code which can change depending on the use-case. I did not manage to get this configurable via helm chart in a reasonable amount of time, so I decided to not publish the image.
I'm open for suggestions here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tom-rm-meyer-ISST could you please have a look if it's possible to make the mock more configurable?
Regarding the local installation:
|
HI @ds-jhartmann thanks I was able to install it but the dataprovider testdata postinstall is failing, that's not the case for you? |
as discussed, it was an issue on my local, install works 👍 |
just commenting that I noticed the following warning as install
as discussed, they appear to be inherent to the new edc version in this install scenario |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed in the last open meeting, it would be great to prepare for easy image override, I hope it's fine that I pushed the change cc5200e
For some reason my comment was still 'pending'. @ds-jhartmann @evegufy I had a check on that as I've not yet done a configuration for python. I think I would be able to achieve a configuration in either of the two ways in around < 0.5PD. The options below only focus on the docker environment vars. Sidenotes:
As some time went by, do we need further configuration options? How should I contribute that? First in PURIS or directly with a branch forked from this branch so that you can merge? I maybe can manage to get this within this or latest by end of next week. I can also adapt it in the puris repo so that one of you can review it and see the delta easily. Option A: configure participants and their key via json array in one environment var
Option B: configure participants dynamically using prefix
|
Hi @tom-rm-meyer-ISST thank you for the input. |
Will try to give it a shot after QGate / R24.08. Which branch should I use to fork from? this one or upgrade/24.05? |
The IAPT mock is not yet available on upgrade/24.05, so I would recommend to fork from this branch |
# Conflicts: # .github/workflows/helm-checks.yaml # charts/tx-data-provider/Chart.yaml # charts/umbrella/Chart.yaml # charts/values-test-shared-services-1.yaml
Description
eclipse-tractusx/sig-release#710
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: