Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Updated MXD to use EDC 0.8.0rc2 #417

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

ieuna
Copy link
Member

@ieuna ieuna commented Aug 30, 2024

Please do not merge this PR.
This setup of MXD is using SAP DIM. The open-source wallet is not compatible with latest versions of EDC. So, creating and testing a full setup of MXD is not possible at the moment.

Description

  1. Updated MXD to use EDC 0.7.1/0.8.0rc2.
  2. Updated Backend Service to use EDC 0.7.1/0.8.0rc2.
  3. Added new endpoint to backend service for processing transfer events(for 0.7.1 and above)
  4. Updated Terraform/K8 configs.
  5. Updated Postmam schema.
  6. Updated Jmeter Script to use backend service and new schema.
  7. Updated documentation to include purpose of backend service, and on how to use backend service image for performance test.

Missing Components

  • Either MIW or an open-source wallet.
  • Integration test for new backend service endpoint(mentioned above).

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link

gitguardian bot commented Aug 30, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13321946 Triggered Generic Private Key 6b09127 mxd/performance-tests/prometheus/prometheus-ingress.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@ieuna ieuna changed the title Updated MXD to EDC 0.8.0rc2 DRAFT: Updated MXD to EDC 0.8.0rc2 Aug 30, 2024
@ieuna ieuna changed the title DRAFT: Updated MXD to EDC 0.8.0rc2 DRAFT: Updated MXD to use EDC 0.8.0rc2 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants