Skip to content

Commit

Permalink
Add notes
Browse files Browse the repository at this point in the history
  • Loading branch information
psolomin committed May 4, 2023
1 parent bb79d40 commit 66b398a
Showing 1 changed file with 9 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,15 @@ static Future<PgConnection> connect(Vertx vertx, String connectionUri) {
*
* @param sql COPY command (example {@code COPY my_table TO STDOUT (FORMAT csv)})
* @return async result of bytes container data will be written to
*
* - vertx.core.stream - https://vertx.io/docs/apidocs/io/vertx/core/streams/ReadStream.html
* - future of read stream.
* - when we do query operation
* - we should not use query result builder
* - what about SELECT 1;SELECT 1 or COPY ....;COPY ... ?
* - we need a new interface Future<ReadStream<Buffer>>
* - https://vertx.io/docs/apidocs/io/vertx/core/streams/ReadStream.html
* - PgSocketConnection - we will apply backpressure in SocketInternal
*/
Future<SqlResult<Buffer>> copyToBytes(String sql);

Expand Down

0 comments on commit 66b398a

Please sign in to comment.